Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757250Ab3DWT0U (ORCPT ); Tue, 23 Apr 2013 15:26:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33332 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757247Ab3DWT0T (ORCPT ); Tue, 23 Apr 2013 15:26:19 -0400 Date: Tue, 23 Apr 2013 12:26:17 -0700 From: Andrew Morton To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, Richard Weinberger , kernel@pengutronix.de Subject: Re: init-mainc-convert-to-pr_foo.patch is IMHO broken Message-Id: <20130423122617.c96d332c2b0c41ea6cf82998@linux-foundation.org> In-Reply-To: <20130423191839.GK15233@pengutronix.de> References: <20130423191839.GK15233@pengutronix.de> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1071 Lines: 38 On Tue, 23 Apr 2013 21:18:39 +0200 Uwe Kleine-K__nig wrote: > Hello, > > init-mainc-convert-to-pr_foo.patch breaks the initcall_debug kernel > parameter. Before the patch I could add > > initcall_debug ignore_loglevel > > to the kernel command line and got some additional output about > initcalls. Now that init/main.c uses pr_debug instead of > printk(KERN_DEBUG ...) the interesting statements are not compiled in > any more. > huh. pr_debug() is different from all the other pr_foo()s. I never noticed that. This? --- a/init/main.c~init-mainc-convert-to-pr_foo-fix +++ a/init/main.c @@ -9,6 +9,8 @@ * Simplified starting of init: Michael A. Griffith */ +#define DEBUG + #include #include #include _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/