From: Arnd Bergmann <arnd@arndb.de>
To: Marc Dietrich <marvin24@gmx.de>
Subject: Re: [PATCH 14/21] staging: nvec: allow modular build
Date: Tue, 23 Apr 2013 21:41:03 +0200
User-Agent: KMail/1.12.2 (Linux/3.8.0-18-generic; KDE/4.3.2; x86_64; ; )
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
References: <1366734653-488286-1-git-send-email-arnd@arndb.de> <1366734653-488286-15-git-send-email-arnd@arndb.de> <4082180.JXNz6TsAKc@ax5200p>
In-Reply-To: <4082180.JXNz6TsAKc@ax5200p>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201304232141.04123.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1186
Lines: 28

On Tuesday 23 April 2013, Marc Dietrich wrote:
> On Tuesday 23 April 2013 18:30:46 Arnd Bergmann wrote:
> > The serio code can be a loadable module, which in turn means that nvec
> > also has to be a module, so mark it as "tristate" in Kconfig.
> 
> oh, I didn't saw this randconfig error posting. NVEC isn't prepared for 
> modularized builds yet (it's on the TODO list though). So better say SERIO=y 
> here. Looking a bit closer, there is other stuff which can also be a module 
> (GPIOLIB, I2C, ...) so these also need a =y.

What is the problem with building it as a module? It looks all fine in that
regard.

I also did not see any problems with the other symbols, but that may be
because they get turned on as built-in even in allmodconfig. Marking it
as tristate certainly avoids the problem altogether.

> Should a post a patch?

If you have follow-on patches, they need to go on top now, since Greg
already took this patch.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/