Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755201Ab3DWUYf (ORCPT ); Tue, 23 Apr 2013 16:24:35 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:56098 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754156Ab3DWUYe (ORCPT ); Tue, 23 Apr 2013 16:24:34 -0400 Date: Tue, 23 Apr 2013 13:24:29 -0700 From: Tejun Heo To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, arvind.chauhan@arm.com, davem@davemloft.net, airlied@redhat.com, axboe@kernel.dk, tglx@linutronix.de, peterz@infradead.org, mingo@redhat.com, rostedt@goodmis.org, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 3/4] block: queue work on unbound wq Message-ID: <20130423202429.GK12543@htj.dyndns.org> References: <91239cde99aaba2715f63db1f88241d9f4a36e13.1364740180.git.viresh.kumar@linaro.org> <20130331181931.GA7533@htj.dyndns.org> <20130409183020.GD6186@mtj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 49 Hello, Viresh. On Mon, Apr 22, 2013 at 11:50:04AM +0530, Viresh Kumar wrote: > On 10 April 2013 00:00, Tejun Heo wrote: > > On Tue, Apr 09, 2013 at 01:00:59PM +0530, Viresh Kumar wrote: > > >> +#ifdef CONFIG_WQ_POWER_EFFICIENT > >> +static bool wq_power_efficient = 0; > >> +module_param_named(power_efficient, wq_power_efficient, bool, 0444); > >> +#endif > > > > I don't think we need to make the whole thing configurable. Turning > > it off isn't gonna save much - my gut tells me it's gonna be four > > instructions. :) > > > > What I meant was that the default value for the parameter would > > probably be need to be configurable so that mobile people don't have > > to include the kernel param all the time or patch the kernel > > themselves. > > I didn't get it completely.. Are you asking to set the default value > to 1 instead > to keep it enabled by default if config option is selected? Oh, sorry about that. I meant something like this. #ifdef CONFIG_WQ_POWER_EFFICIENT_BY_DEFAULT // or something prettier static bool wq_power_efficient = true; #else static bool wq_power_efficient = false; #endif module_param.... And its Kconfig entry config WQ_POWER_EFFICIENT_BY_DEFAULT bool "Blah Blah Viresh is awesome" default n Thanks! -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/