Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756284Ab3DXBBB (ORCPT ); Tue, 23 Apr 2013 21:01:01 -0400 Received: from terminus.zytor.com ([198.137.202.10]:35802 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755281Ab3DXBBA (ORCPT ); Tue, 23 Apr 2013 21:01:00 -0400 Message-ID: <51772EBC.1050600@zytor.com> Date: Tue, 23 Apr 2013 18:00:44 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Tetsuo Handa CC: arjan@infradead.org, james.hogan@imgtec.com, rusty@rustcorp.com.au, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com Subject: Re: [PATCH] x86_32: Fix module version table mismatch. References: <201304222326.IJB21395.FOtVJFHFQMOOSL@I-love.SAKURA.ne.jp> <201304232140.FGF73904.QJOFOVtHFFMSOL@I-love.SAKURA.ne.jp> <51772CD3.3040405@zytor.com> In-Reply-To: <51772CD3.3040405@zytor.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 31 On 04/23/2013 05:52 PM, H. Peter Anvin wrote: > On 04/23/2013 05:40 AM, Tetsuo Handa wrote: >> Commit a4b6a77b "module: fix symbol versioning with symbol prefixes" broke >> loading of net/ipv6/ipv6.ko built with CONFIG_MODVERSIONS=y for x86_32. > > This really does seem to be the offending commit, although I'm still > confused how the heck that is possible. > OK, now I grok. The bug is the use of VMLINUX_SYMBOL_STR(%s) which expands at the time the output of modpost is compiled. However, VMLINUX_SYMBOL_STR() unlike __VMLINUX_SYMBOL_STR() does macro expansion on its argument, which is actively wrong here. I think the choice is either to change this to __VMLINUX_SYMBOL_STR() or re-introduce CONFIG_SYMBOL_PREFIX (or its equivalent) so that modprobe can emit it at compile time (assuming there even should *be* a prefix on the symbol here, i.e. that the compiler won't add it.) Either way -- James, Rusty, this is in your court. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/