Message-ID: <51774D33.5090708@nvidia.com>
Date: Wed, 24 Apr 2013 11:10:43 +0800
From: Mark Zhang <markz@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5
MIME-Version: 1.0
To: Wei Yongjun <weiyj.lk@gmail.com>
CC: "thierry.reding@avionic-design.de" <thierry.reding@avionic-design.de>,
        Terje Bergstrom <tbergstrom@nvidia.com>,
        Arto Merilainen <amerilainen@nvidia.com>,
        Stephen Warren <swarren@nvidia.com>,
        "yongjun_wei@trendmicro.com.cn" <yongjun_wei@trendmicro.com.cn>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next RESEND] gpu: host1x: drm: fix missing unlock on
 error
References: <CAPgLHd8X3pLTM5vsTnHWL3g9GNOrxVF-LkmGWp6_doFkX2_LcQ@mail.gmail.com> <5177490E.7040509@nvidia.com> <CAPgLHd981uTJHuQAE_komRn81nce8zdzr+a-v43VJSPCDBgRiQ@mail.gmail.com>
In-Reply-To: <CAPgLHd981uTJHuQAE_komRn81nce8zdzr+a-v43VJSPCDBgRiQ@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1958
Lines: 60

Alright. Please send this to linux-tegra ML and ping Thierry.

Mark
On 04/24/2013 11:07 AM, Wei Yongjun wrote:
> On 04/24/2013 10:53 AM, Mark Zhang wrote:
>> I think Thierry has acked this patch. So why?
> 
> Yes, Thierry has acked this patch five months ago, but this patch does not
> applied util now. And the source file has been moved from
> drivers/gpu/drm/tegra/host1x.c to drivers/gpu/host1x/drm/drm.c, so I am not
> sure whether this patch was lost.
> 
> Regards,
> Yongjun Wei 
> 
> 
>>
>> Mark
>> On 04/24/2013 10:48 AM, Wei Yongjun wrote:
>>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>>
>>> Add the missing unlock before return from function host1x_drm_init() and
>>> host1x_drm_exit() in the error handling case.
>>>
>>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>> ---
>>> rebased on the latest linux-next.git tree.
>>> ---
>>>  drivers/gpu/host1x/drm/drm.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/gpu/host1x/drm/drm.c b/drivers/gpu/host1x/drm/drm.c
>>> index 2b561c9..0dbb9c0 100644
>>> --- a/drivers/gpu/host1x/drm/drm.c
>>> +++ b/drivers/gpu/host1x/drm/drm.c
>>> @@ -148,6 +148,7 @@ int host1x_drm_init(struct host1x_drm *host1x, struct drm_device *drm)
>>>  				dev_err(host1x->dev,
>>>  					"DRM setup failed for %s: %d\n",
>>>  					dev_name(client->dev), err);
>>> +				mutex_unlock(&host1x->clients_lock);
>>>  				return err;
>>>  			}
>>>  		}
>>> @@ -175,6 +176,7 @@ int host1x_drm_exit(struct host1x_drm *host1x)
>>>  				dev_err(host1x->dev,
>>>  					"DRM cleanup failed for %s: %d\n",
>>>  					dev_name(client->dev), err);
>>> +				mutex_unlock(&host1x->clients_lock);
>>>  				return err;
>>>  			}
>>>  		}
>>>
>>
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/