Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757943Ab3DXIv3 (ORCPT ); Wed, 24 Apr 2013 04:51:29 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:59266 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359Ab3DXIv0 (ORCPT ); Wed, 24 Apr 2013 04:51:26 -0400 Date: Wed, 24 Apr 2013 09:51:21 +0100 From: Lee Jones To: Vinod Koul Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linus.walleij@stericsson.com, Dan Williams , Per Forlin , Rabin Vincent Subject: Re: [PATCH 15/32] dmaengine: ste_dma40: Separate Logical Global Interrupt Mask (GIM) unmasking Message-ID: <20130424085121.GI17416@gmail.com> References: <1366279934-30761-1-git-send-email-lee.jones@linaro.org> <1366279934-30761-16-git-send-email-lee.jones@linaro.org> <20130422095130.GM24632@intel.com> <20130422104012.GL3432@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130422104012.GL3432@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 27 On Mon, 22 Apr 2013, Lee Jones wrote: > > > void d40_phy_cfg(struct stedma40_chan_cfg *cfg, > > > u32 *src_cfg, u32 *dst_cfg, bool is_log) > > > @@ -107,11 +113,6 @@ void d40_phy_cfg(struct stedma40_chan_cfg *cfg, > > > src |= 1 << D40_SREG_CFG_PRI_POS; > > > dst |= 1 << D40_SREG_CFG_PRI_POS; > > shouldnt these be converted to BIT() macro and in gim_unmask above? > > Driver needs to be consistent in doing things > > Absolutely they do. I haven't converted ste_dma40_ll.c to BIT yet > though. I have this on my TODO and it will happen in the next > patch-set. Vinod, are you happy to Ack this on the proviso that I follow it up with a subsequent patch converting the ste_dma40_ll driver to BIT()? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/