Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932101Ab3DXK4P (ORCPT ); Wed, 24 Apr 2013 06:56:15 -0400 Received: from mail-ea0-f170.google.com ([209.85.215.170]:60672 "EHLO mail-ea0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758117Ab3DXK4O (ORCPT ); Wed, 24 Apr 2013 06:56:14 -0400 Date: Wed, 24 Apr 2013 12:56:10 +0200 From: Ingo Molnar To: Borislav Petkov Cc: X86 ML , LKML , Borislav Petkov , Matthew Garrett , Matt Fleming Subject: Re: [PATCH] x86, efi: Fix a build warning Message-ID: <20130424105610.GA15815@gmail.com> References: <1366798154-1380-1-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366798154-1380-1-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1864 Lines: 47 * Borislav Petkov wrote: > From: Borislav Petkov > > Fix this: > > arch/x86/boot/compressed/eboot.c: In function ???setup_efi_vars???: > arch/x86/boot/compressed/eboot.c:269:2: warning: passing argument 1 of ???efi_call_phys??? makes pointer from integer without a cast [enabled by default] > In file included from arch/x86/boot/compressed/eboot.c:12:0: > /w/kernel/linux/arch/x86/include/asm/efi.h:8:33: note: expected ???void *??? but argument is of type ???long unsigned int??? > > after cc5a080c5d40 ("efi: Pass boot services variable info to runtime > code"). > > Cc: Matthew Garrett > Cc: Matt Fleming > Signed-off-by: Borislav Petkov > --- > arch/x86/boot/compressed/eboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c > index 8615f7581820..41de115a55b7 100644 > --- a/arch/x86/boot/compressed/eboot.c > +++ b/arch/x86/boot/compressed/eboot.c > @@ -266,7 +266,7 @@ static efi_status_t setup_efi_vars(struct boot_params *params) > while (data && data->next) > data = (struct setup_data *)(unsigned long)data->next; > > - status = efi_call_phys4(sys_table->runtime->query_variable_info, > + status = efi_call_phys4((void *)sys_table->runtime->query_variable_info, > EFI_VARIABLE_NON_VOLATILE | > EFI_VARIABLE_BOOTSERVICE_ACCESS | > EFI_VARIABLE_RUNTIME_ACCESS, &store_size, Why isn't the query_variale_info field changed to void * instead? That way no cast would be needed. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/