Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756424Ab3DXOuF (ORCPT ); Wed, 24 Apr 2013 10:50:05 -0400 Received: from merlin.infradead.org ([205.233.59.134]:53732 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903Ab3DXOuC (ORCPT ); Wed, 24 Apr 2013 10:50:02 -0400 Date: Wed, 24 Apr 2013 08:49:57 -0600 From: Jens Axboe To: James Bottomley Cc: Namjae Jeon , "linux-kernel@vger.kernel.org" , Namjae Jeon , "stable@vger.kernel.org" Subject: Re: [PATCH] block: fix max discard sectors limit Message-ID: <20130424144957.GH2759@kernel.dk> References: <1366811721-2478-1-git-send-email-linkinjeon@gmail.com> <1366813389.1971.1.camel@dabdike> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366813389.1971.1.camel@dabdike> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2317 Lines: 59 On Wed, Apr 24 2013, James Bottomley wrote: > On Wed, 2013-04-24 at 22:55 +0900, Namjae Jeon wrote: > > From: James Bottomley > > > > linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with > > commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9 > > (block: add plug for blkdev_issue_discard ) > > > > For example, > > 1) DISCARD rq-1 with size size 4GB > > 2) DISCARD rq-2 with size size 1GB > > > > If these 2 discard requests get merged, final request size will be 5GB. > > > > In this case, request's __data_len field may overflow as it can store > > max 4GB(unsigned int). > > > > This issue was observed while doing mkfs.f2fs on 5GB SD card: > > https://lkml.org/lkml/2013/4/1/292 > > > > Info: sector size = 512 > > Info: total sectors = 11370496 (in 512bytes) > > Info: zone aligned segment0 blkaddr: 512 > > [ 257.789764] blk_update_request: bio idx 0 >= vcnt 0 > > > > mkfs process gets stuck in D state and I see the following in the dmesg: > > > > [ 257.789733] __end_that: dev mmcblk0: type=1, flags=122c8081 > > [ 257.789764] sector 4194304, nr/cnr 2981888/4294959104 > > [ 257.789764] bio df3840c0, biotail df3848c0, buffer (null), len > > 1526726656 > > [ 257.789764] blk_update_request: bio idx 0 >= vcnt 0 > > [ 257.794921] request botched: dev mmcblk0: type=1, flags=122c8081 > > [ 257.794921] sector 4194304, nr/cnr 2981888/4294959104 > > [ 257.794921] bio df3840c0, biotail df3848c0, buffer (null), len > > 1526726656 > > > > This patch fixes this issue. > > > > Reported-by: Max Filippov > > Signed-off-by: Namjae Jeon > > Signed-off-by: James Bottomley > > Tested-by: Max Filippov > > Cc: > > The two signoffs need to be reversed (they follow the chain of > transmission from the author into the kernel), but other than that, this > looks great. I assume Jens can just hand edit this one issue. Yeah, I'll just hand edit thank. Thanks all. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/