Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757816Ab3DXTpf (ORCPT ); Wed, 24 Apr 2013 15:45:35 -0400 Received: from terminus.zytor.com ([198.137.202.10]:46876 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757465Ab3DXTpb (ORCPT ); Wed, 24 Apr 2013 15:45:31 -0400 Message-ID: <5178282D.9030902@zytor.com> Date: Wed, 24 Apr 2013 11:45:01 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Oleg Nesterov CC: Ingo Molnar , Linus Torvalds , Cyrill Gorcunov , Peter Zijlstra , Thomas Gleixner , David Miller , "Theodore Ts'o" , Linux Kernel Mailing List , the arch/x86 maintainers , Network Development , "linux-ext4@vger.kernel.org" , Fr??d??ric Weisbecker Subject: Re: [PATCH] x86: make DR*_RESERVED unsigned long References: <20130424072630.GB1780@gmail.com> <20130424170702.GA1867@redhat.com> In-Reply-To: <20130424170702.GA1867@redhat.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 954 Lines: 25 On 04/24/2013 10:07 AM, Oleg Nesterov wrote: > DR6_RESERVED and DR_CONTROL_RESERVED are used to clear the set > bits in the "unsigned long" data, make them long to ensure that > "&~" doesn't clear the upper bits. > > do_debug() and ptrace_write_dr7() which use DR*_RESERVED look > safe, but probably it makes sense to cleanup anyway. > > Reported-by: Linus Torvalds > Signed-off-by: Oleg Nesterov Can you please put in the description if this is a manifest or non-manifest bug and, if manifest, what the issues are? It greatly affects what we otherwise have to do to address the bug. Also, the -UL suffix is usually capitalized in our codebase. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/