Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754233Ab3DYGpU (ORCPT ); Thu, 25 Apr 2013 02:45:20 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:57547 "EHLO e28smtp08.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120Ab3DYGpS (ORCPT ); Thu, 25 Apr 2013 02:45:18 -0400 Message-ID: <5178D049.9090303@linux.vnet.ibm.com> Date: Thu, 25 Apr 2013 12:12:17 +0530 From: "Srivatsa S. Bhat" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Kevin Hilman CC: Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org, Linus Torvalds , Rusty Russell , Paul McKenney , Peter Zijlstra , Magnus Damm Subject: Re: [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle References: <1366849153-25564-1-git-send-email-khilman@linaro.org> In-Reply-To: <1366849153-25564-1-git-send-email-khilman@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13042506-2000-0000-0000-00000BDCF4D1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2038 Lines: 58 On 04/25/2013 05:49 AM, Kevin Hilman wrote: > commit d1669912 (idle: Implement generic idle function) added a new > generic idle along with support for hlt/nohlt command line options to > override default idle loop behavior. However, the command-line > processing is never compiled. > > The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP > and arches that use this feature select it in their Kconfigs. > However, no Kconfig definition was created for this option, so it is > never enabled, and therefore command-line override of the idle-loop > behavior is broken after migrating to the generic idle loop. > > To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP. > > Tested on ARM (OMAP4/Panda) which enables the command-line overrides > by default. > > Cc: Thomas Gleixner > Cc: Linus Torvalds > Cc: Rusty Russell > Cc: Paul McKenney > Cc: Peter Zijlstra > Cc: Srivatsa S. Bhat > Cc: Magnus Damm > Signed-off-by: Kevin Hilman > --- Reviewed-by: Srivatsa S. Bhat Regards, Srivatsa S. Bhat > Applies on tip/smp/hotplug where generic idle feature is added > > arch/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 1455579..e0ef57b 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS > config GENERIC_SMP_IDLE_THREAD > bool > > +config GENERIC_IDLE_POLL_SETUP > + bool > + > # Select if arch init_task initializer is different to init/init_task.c > config ARCH_INIT_TASK > bool > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/