Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950Ab3DYItz (ORCPT ); Thu, 25 Apr 2013 04:49:55 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:60330 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751063Ab3DYItx (ORCPT ); Thu, 25 Apr 2013 04:49:53 -0400 Date: Thu, 25 Apr 2013 09:49:33 +0100 From: Will Deacon To: Stefano Stabellini Cc: "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "arnd@arndb.de" , "nicolas.pitre@linaro.org" , "rob.herring@calxeda.com" , "linux@arm.linux.org.uk" , "olof@lixom.net" , Jon Medhurst Subject: Re: [PATCH v8 2/2] ARM: Enable selection of SMP operations at boot time Message-ID: <20130425084933.GB12848@mudshark.cambridge.arm.com> References: <1366828819-10745-2-git-send-email-stefano.stabellini@eu.citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366828819-10745-2-git-send-email-stefano.stabellini@eu.citrix.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1606 Lines: 49 On Wed, Apr 24, 2013 at 07:40:19PM +0100, Stefano Stabellini wrote: > From: Jon Medhurst > > Add a new 'smp_init' hook to machine_desc so platforms can specify a > function to be used to setup smp ops instead of having a statically > defined value. The hook must return true when smp_ops are initialized. > If false the static mdesc->smp_ops will be used by default. > > Signed-off-by: Jon Medhurst > Signed-off-by: Nicolas Pitre > Signed-off-by: Stefano Stabellini > Reviewed-by: Santosh Shilimkar > --- > arch/arm/include/asm/mach/arch.h | 4 ++++ > arch/arm/kernel/setup.c | 10 ++++++---- > 2 files changed, 10 insertions(+), 4 deletions(-) [...] > if (is_smp()) { > - if (psci_smp_available()) > - smp_set_ops(&psci_smp_ops); > - else if (mdesc->smp) > - smp_set_ops(mdesc->smp); > + if (!mdesc->smp_init || !mdesc->smp_init()) { Minor nit, but this feels backwards to me. We usually return 0 on success, yet we're saying here that if mdesc->smp_init() returns 0, then we go and override the smp ops. Will > + if (psci_smp_available()) > + smp_set_ops(&psci_smp_ops); > + else if (mdesc->smp) > + smp_set_ops(mdesc->smp); > + } > smp_init_cpus(); > } > #endif > -- > 1.7.2.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/