Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932103Ab3DYLSA (ORCPT ); Thu, 25 Apr 2013 07:18:00 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:46109 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754383Ab3DYLR6 (ORCPT ); Thu, 25 Apr 2013 07:17:58 -0400 MIME-Version: 1.0 In-Reply-To: <1366279934-30761-21-git-send-email-lee.jones@linaro.org> References: <1366279934-30761-1-git-send-email-lee.jones@linaro.org> <1366279934-30761-21-git-send-email-lee.jones@linaro.org> Date: Thu, 25 Apr 2013 13:17:58 +0200 Message-ID: Subject: Re: [PATCH 20/32] dmaengine: ste_dma40: Move rev error-check up to revision acquisition From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Vinod Koul , Dan Williams , Per Forlin , Rabin Vincent Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 22 On Thu, Apr 18, 2013 at 12:12 PM, Lee Jones wrote: > At the moment we fetch the hardware revision, then do some stuff, then > check whether the revision is correct and return in error if it's not. > Well we may as well check it as soon as we know what it is, so let's > move the check right up underneath where we acquire the version. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Signed-off-by: Lee Jones Reviewed-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/