Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758212Ab3DYL1Z (ORCPT ); Thu, 25 Apr 2013 07:27:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38400 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756264Ab3DYL1Y (ORCPT ); Thu, 25 Apr 2013 07:27:24 -0400 Message-ID: <5179130D.7080707@redhat.com> Date: Thu, 25 Apr 2013 13:27:09 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Alexandru Copot CC: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, akpm@linux-foundation.org, davem@davemloft.net, willemb@google.com, ebiederm@xmission.com, gorcunov@openvz.org, palewis@adobe.com, edumazet@google.com, Daniel Baluta Subject: Re: [PATCH 0/3 RFC v2] selftests: Basic framework for tests References: <1366887900-24769-1-git-send-email-alex.mihai.c@gmail.com> In-Reply-To: <1366887900-24769-1-git-send-email-alex.mihai.c@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2478 Lines: 55 On 04/25/2013 01:04 PM, Alexandru Copot wrote: > This series adds a generic test abstraction that can make > writing testcases easier. A generic_test structure is > used to define a test and its methods: prepare, run, cleanup. > > This is a generic implementation so it was placed in selftests/lib. > > The second patch updates the socket tests to use the > new framework and the third patch creates new tests > for [set/get]sockopt with some IPV6_* options. This already looks better than the previous one. I will probably go a bit more in depth through the code in the evening. A couple of minor general items I can already tell you: > Signed-of-by Alexandru Copot It's: Signed-off-by: Alexandru Copot You have this wrong in all your patches. Also, in patches 1-3 a proper commit message would be nice, i.e. in patch 1 when you add the library that everyone should use. It could be that your cover letter will not go into the Git history, thus people will only see you empty commit bodies. > Cc: Daniel Baluta > > Changes since v1: > - moved the implementation to selftests/lib > - use goto instead of directly returning > > Alexandru Copot (3): > selftests: introduce testing abstractions > selftests/net: update socket test to use new testing framework > selftests/net: add socket options test with IPv6 testcases > > tools/testing/selftests/Makefile | 3 +- > tools/testing/selftests/lib/Makefile | 14 ++ > tools/testing/selftests/lib/selftests.c | 57 +++++++++ > tools/testing/selftests/lib/selftests.h | 67 ++++++++++ > tools/testing/selftests/net/Makefile | 17 ++- > tools/testing/selftests/net/run_netsocktests | 10 ++ > tools/testing/selftests/net/socket.c | 108 +++++++++++----- > tools/testing/selftests/net/sockopt.c | 185 +++++++++++++++++++++++++++ > 8 files changed, 425 insertions(+), 36 deletions(-) > create mode 100644 tools/testing/selftests/lib/Makefile > create mode 100644 tools/testing/selftests/lib/selftests.c > create mode 100644 tools/testing/selftests/lib/selftests.h > create mode 100644 tools/testing/selftests/net/sockopt.c -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/