Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758327Ab3DYMCN (ORCPT ); Thu, 25 Apr 2013 08:02:13 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:42938 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756751Ab3DYMCL (ORCPT ); Thu, 25 Apr 2013 08:02:11 -0400 MIME-Version: 1.0 In-Reply-To: <1366280825-31136-7-git-send-email-lee.jones@linaro.org> References: <1366280825-31136-1-git-send-email-lee.jones@linaro.org> <1366280825-31136-7-git-send-email-lee.jones@linaro.org> Date: Thu, 25 Apr 2013 14:02:11 +0200 Message-ID: Subject: Re: [PATCH 6/9] crypto: ux500/cryp - Set DMA configuration though dma_slave_config() From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Herbert Xu , "David S. Miller" , Andreas Westin , "linux-crypto@vger.kernel.org" , magnus.p.persson@stericsson.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1678 Lines: 47 On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones wrote: > The DMA controller currently takes configuration information from > information passed though dma_channel_request(), but it shouldn't. > Using the API, the DMA channel should only be configured during > a dma_slave_config() call. > > Cc: Herbert Xu > Cc: David S. Miller > Cc: Andreas Westin > Cc: linux-crypto@vger.kernel.org > Signed-off-by: Lee Jones (...) > /* Cryp DMA interface */ > +#define HASH_DMA_TX_FIFO 0x08 > +#define HASH_DMA_RX_FIFO 0x10 Yes, this is nice address notation :-) > /** > * struct cryp_device_data - structure for a cryp device. > - * @base: Pointer to the hardware base address. > + * @base: Pointer to virtual base address of the cryp device. > + * @phybase: Pointer to physical memory location of the cryp device. > * @dev: Pointer to the devices dev structure. > * @clk: Pointer to the device's clock control. > * @pwr_regulator: Pointer to the device's power control. > @@ -232,6 +236,7 @@ struct cryp_dma { > */ > struct cryp_device_data { > struct cryp_register __iomem *base; > + phys_addr_t phybase; Use dma_addr_t. Maybe "phybase" is misleading, "dmabase" is probably better. (Also applies to the cryp patch). Apart from that it looks allright. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/