Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758734Ab3DYOWD (ORCPT ); Thu, 25 Apr 2013 10:22:03 -0400 Received: from www.linutronix.de ([62.245.132.108]:44199 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757413Ab3DYOWB (ORCPT ); Thu, 25 Apr 2013 10:22:01 -0400 Date: Thu, 25 Apr 2013 16:21:58 +0200 (CEST) From: Thomas Gleixner To: Marc Kleine-Budde cc: Shawn Guo , Nicolas Ferre , linux-kernel@vger.kernel.org, arm@kernel.org, John Stultz , "kernel@pengutronix.de" , Andres Salomon , linux-arm-kernel@lists.infradead.org Subject: Re: RFC: [PATCH] clocksource: tcb: fix min_delta calculation In-Reply-To: <1366722524-25991-1-git-send-email-mkl@pengutronix.de> Message-ID: References: <517687AB.1040309@pengutronix.de> <1366722524-25991-1-git-send-email-mkl@pengutronix.de> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1947 Lines: 55 On Tue, 23 Apr 2013, Marc Kleine-Budde wrote: > The commit > > 77cc982 clocksource: use clockevents_config_and_register() where possible > > switches from manually calculating min_delta_ns (and others) and > clockevents_register_device() to automatic calculation via > clockevents_config_and_register(). During this conversation the "+ 1" in > > min_delta_ns = clockevent_delta2ns(1, &clkevt.clkevt) + 1; > > was lost. This leads to problems with schedule_delayed_work() with a delay of > "1". Resulting in the work not scheduled in time. Errm. How is schedule_delayed_work() related to this? schedule_delayed_work() is jiffies based and has absolutely nothing to do with clockevents. > This patch fixes the problem by increasing the min_delta to "2" ticks. This changelog sucks. > Signed-off-by: Marc Kleine-Budde > --- > drivers/clocksource/tcb_clksrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c > index 8a61872..7cf6dc7 100644 > --- a/drivers/clocksource/tcb_clksrc.c > +++ b/drivers/clocksource/tcb_clksrc.c > @@ -197,7 +197,7 @@ static void __init setup_clkevents(struct atmel_tc *tc, int clk32k_divisor_idx) > > clkevt.clkevt.cpumask = cpumask_of(0); > > - clockevents_config_and_register(&clkevt.clkevt, 32768, 1, 0xffff); > + clockevents_config_and_register(&clkevt.clkevt, 32768, 2, 0xffff); > > setup_irq(irq, &tc_irqaction); > } > -- > 1.8.2.rc2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/