Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933042Ab3DYRgU (ORCPT ); Thu, 25 Apr 2013 13:36:20 -0400 Received: from gate.crashing.org ([63.228.1.57]:56557 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932340Ab3DYRgS (ORCPT ); Thu, 25 Apr 2013 13:36:18 -0400 Message-ID: <1366911329.2869.31.camel@pasglop> Subject: Re: [PATCH 1/5] ibmebus: convert of_platform_driver to platform_driver From: Benjamin Herrenschmidt To: Rob Herring Cc: "linux-kernel@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , Grant Likely , Arnd Bergmann , Paul Mackerras , Hoang-Nam Nguyen , Christoph Raisch , Roland Dreier , Sean Hefty , Hal Rosenstock , Thadeu Lima de Souza Cascardo , linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org Date: Fri, 26 Apr 2013 03:35:30 +1000 In-Reply-To: References: <1366596798-9457-1-git-send-email-robherring2@gmail.com> <1366596798-9457-2-git-send-email-robherring2@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.2-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2450 Lines: 46 On Thu, 2013-04-25 at 10:23 -0500, Rob Herring wrote: > Ben, Can I have your Ack for this? The change is straightforward and > neither of the 2 drivers used the id parameter that is removed. Didn't you get my mail about a compile failure caused by this patch ? Or did you send an update that I missed ? (Copy of the original email below) Cheers, Ben. ---- On Sun, 2013-04-21 at 21:13 -0500, Rob Herring wrote: > From: Rob Herring > > ibmebus is the last remaining user of of_platform_driver and the > conversion to a regular platform driver is trivial. A quick build test leads to: /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function 'ibmebus_bus_device_probe': /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:344:2: error: implicit declaration of function 'to_platform_driver' [-Werror=implicit-function-declaration] /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:344:6: error: assignment makes pointer from integer without a cast [-Werror] /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function 'ibmebus_bus_device_remove': /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:363:32: error: initialization makes pointer from integer without a cast [-Werror] /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function 'ibmebus_bus_device_shutdown': /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:373:32: error: initialization makes pointer from integer without a cast [-Werror] /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function 'ibmebus_bus_legacy_suspend': /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:420:32: error: initialization makes pointer from integer without a cast [-Werror] /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c: In function 'ibmebus_bus_legacy_resume': /home/benh/linux-powerpc-test/arch/powerpc/kernel/ibmebus.c:431:32: error: initialization makes pointer from integer without a cast [-Werror] cc1: all warnings being treated as errors make[2]: *** [arch/powerpc/kernel/ibmebus.o] Error 1 make[2]: *** Waiting for unfinished jobs.... Haven't had a chance to look too closely today -EJETLAG :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/