Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933151Ab3DYR7y (ORCPT ); Thu, 25 Apr 2013 13:59:54 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:38448 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932096Ab3DYR7x (ORCPT ); Thu, 25 Apr 2013 13:59:53 -0400 Date: Thu, 25 Apr 2013 10:59:50 -0700 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Felipe Balbi , Pavankumar Kondeti Subject: Re: [PATCH 18/21] USB: ehci-msm: USB_MSM_OTG needs USB_PHY Message-ID: <20130425175950.GA14654@kroah.com> References: <1366910944-3033663-1-git-send-email-arnd@arndb.de> <1366910944-3033663-19-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366910944-3033663-19-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2087 Lines: 58 On Thu, Apr 25, 2013 at 07:29:01PM +0200, Arnd Bergmann wrote: > The Kconfig entry for USB_EHCI_MSM unconditionally selects USB_MSM_OTG, > which is now only visible when USB_PHY is also enabled. > > This adds an appropriate dependency and enables USB_PHY in the msm > defconfig, avoiding the Kbuild warning: > > warning: (USB_EHCI_MSM) selects USB_MSM_OTG which has unmet direct dependencies (USB_SUPPORT && USB_PHY && (USB || USB_GADGET) && ARCH_MSM) > > Signed-off-by: Arnd Bergmann > Cc: linux-usb@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: Felipe Balbi > Cc: Pavankumar Kondeti > --- > arch/arm/configs/msm_defconfig | 1 + > drivers/usb/host/Kconfig | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/arch/arm/configs/msm_defconfig b/arch/arm/configs/msm_defconfig > index 44f9291..690b5f9 100644 > --- a/arch/arm/configs/msm_defconfig > +++ b/arch/arm/configs/msm_defconfig > @@ -101,6 +101,7 @@ CONFIG_SND_DYNAMIC_MINORS=y > CONFIG_SND_SOC=y > CONFIG_HID_BATTERY_STRENGTH=y > CONFIG_USB=y > +CONFIG_USB_PHY=y > CONFIG_USB_ANNOUNCE_NEW_DEVICES=y > CONFIG_USB_MON=y > CONFIG_USB_EHCI_HCD=y This part of the patch doesn't apply to my tree, so I can't take it. > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > index c558472..de94f26 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -188,6 +188,7 @@ config USB_EHCI_HCD_AT91 > config USB_EHCI_MSM > tristate "Support for Qualcomm QSD/MSM on-chip EHCI USB controller" > depends on ARCH_MSM > + depends on USB_PHY > select USB_EHCI_ROOT_HUB_TT > select USB_MSM_OTG > ---help--- But this does, and I'm guessing that it's the more important part, so I'll just edit it and only take this hunk, ok? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/