Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758305Ab3DZFkE (ORCPT ); Fri, 26 Apr 2013 01:40:04 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34845 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753957Ab3DZFkB (ORCPT ); Fri, 26 Apr 2013 01:40:01 -0400 Date: Fri, 26 Apr 2013 07:40:00 +0200 Message-ID: From: Takashi Iwai To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 06/21] ALSA: ali5451: use mdelay instead of large udelay constants In-Reply-To: <1366910944-3033663-7-git-send-email-arnd@arndb.de> References: <1366910944-3033663-1-git-send-email-arnd@arndb.de> <1366910944-3033663-7-git-send-email-arnd@arndb.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1801 Lines: 62 At Thu, 25 Apr 2013 19:28:49 +0200, Arnd Bergmann wrote: > > ARM cannot handle udelay for more than 2 miliseconds, so we > should use mdelay instead for those. > > Signed-off-by: Arnd Bergmann > Cc: Takashi Iwai > Cc: alsa-devel@alsa-project.org Thanks, applied to sound git tree. Takashi > --- > sound/pci/ali5451/ali5451.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c > index e760af9..53754f5 100644 > --- a/sound/pci/ali5451/ali5451.c > +++ b/sound/pci/ali5451/ali5451.c > @@ -451,10 +451,10 @@ static int snd_ali_reset_5451(struct snd_ali *codec) > if (pci_dev) { > pci_read_config_dword(pci_dev, 0x7c, &dwVal); > pci_write_config_dword(pci_dev, 0x7c, dwVal | 0x08000000); > - udelay(5000); > + mdelay(5); > pci_read_config_dword(pci_dev, 0x7c, &dwVal); > pci_write_config_dword(pci_dev, 0x7c, dwVal & 0xf7ffffff); > - udelay(5000); > + mdelay(5); > } > > pci_dev = codec->pci; > @@ -463,14 +463,14 @@ static int snd_ali_reset_5451(struct snd_ali *codec) > udelay(500); > pci_read_config_dword(pci_dev, 0x44, &dwVal); > pci_write_config_dword(pci_dev, 0x44, dwVal & 0xfffbffff); > - udelay(5000); > + mdelay(5); > > wCount = 200; > while(wCount--) { > wReg = snd_ali_codec_peek(codec, 0, AC97_POWERDOWN); > if ((wReg & 0x000f) == 0x000f) > return 0; > - udelay(5000); > + mdelay(5); > } > > /* non-fatal if you have a non PM capable codec */ > -- > 1.8.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/