Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759549Ab3DZJde (ORCPT ); Fri, 26 Apr 2013 05:33:34 -0400 Received: from mail-ee0-f42.google.com ([74.125.83.42]:57345 "EHLO mail-ee0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756854Ab3DZJdb (ORCPT ); Fri, 26 Apr 2013 05:33:31 -0400 Date: Fri, 26 Apr 2013 11:33:27 +0200 From: Ingo Molnar To: "Li, Fei" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "Liu, Chuansheng" , "tomoki.sekiyama.qu@hitachi.com" , "suresh.b.siddha@intel.com" , "joe@perches.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86: eliminate irq_mis_count counted in arch_irq_stat Message-ID: <20130426093327.GA1933@gmail.com> References: <1366962971.32469.4.camel@fli24-HP-Compaq-8100-Elite-CMT-PC> <20130426081915.GA1450@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1434 Lines: 40 * Li, Fei wrote: > > > Signed-off-by: Liu Chuansheng > > > Signed-off-by: Li Fei > > > > The patch looks good, but this is not a valid signoff sequence. If Liu > > Chuansheng wrote this patch then his From: line should be included. If he > > acked it, then it should be added as Acked-by. > > > Hello Ingo, > Thanks for your quick feedback. > > I add Chuansheng's signature basing on: > 1> Chuansheng found such hole in code; > 2> After discussion with Chuansheng, I wrote the patch; > 3> Chuansheng also acked it. > > Do you think it's OK to add Chuansheng's signature in such case? > Or better suggestion? Signed-off-by has a specific meaning, it typically means someone authored or as a maintainer forwarded the code (which did not happen here) - see the details in Documentation/SubmittingPatches, under this section: 12) Sign your work If Chuansheng found the bug, there's a Reported-by tag. If Chuansheng approves of the fix patch then there's Acked-by for that. If he tested it, then for that there's the Tested-by tag. You can also add several of those tags. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/