Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756489Ab3DZMi5 (ORCPT ); Fri, 26 Apr 2013 08:38:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46185 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754114Ab3DZMiz (ORCPT ); Fri, 26 Apr 2013 08:38:55 -0400 Message-ID: <517A754A.8030902@redhat.com> Date: Fri, 26 Apr 2013 14:38:34 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Xi Wang CC: Heiko Carstens , "David S. Miller" , Russell King , Eric Dumazet , Will Drewry , Andrew Morton , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Schichan , Mircea Gherzan Subject: Re: [RFC PATCH net-next 0/6] seccomp filter JIT References: <1366962706-24204-1-git-send-email-xi.wang@gmail.com> <20130426112539.GA3736@osiris> <517A6915.2020208@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1258 Lines: 33 On 04/26/2013 02:31 PM, Xi Wang wrote: > On Fri, Apr 26, 2013 at 7:46 AM, Daniel Borkmann wrote: >> I think BPF JIT for seccomp on ARM recently got applied to -mm tree >> if I'm not mistaken. It was from Nicolas Schichan (cc): >> >> http://thread.gmane.org/gmane.linux.ports.arm.kernel/233416/ > > Thanks for the pointer. > > For the ARM part, looks like Nicolas's patch requires to implement two > wrappers for each arch: > > void seccomp_jit_compile(struct seccomp_filter *fp); > void seccomp_jit_free(struct seccomp_filter *fp); > > The implementation of these wrappers is almost identical to: > > void bpf_jit_compile(struct sk_filter *fp); > void bpf_jit_free(struct sk_filter *fp); > > While this patch uses a unified interface for both packet & seccomp filters. > > bpf_func_t bpf_jit_compile(struct sock_filter *filter, unsigned int flen); > void bpf_jit_free(bpf_func_t bpf_func); A unified interface seems more clean, imho. > Shouldn't be hard to merge though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/