Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755144Ab3DZO2R (ORCPT ); Fri, 26 Apr 2013 10:28:17 -0400 Received: from mail-we0-f182.google.com ([74.125.82.182]:61140 "EHLO mail-we0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108Ab3DZO2Q (ORCPT ); Fri, 26 Apr 2013 10:28:16 -0400 Date: Fri, 26 Apr 2013 15:28:10 +0100 From: Lee Jones To: Linus Walleij Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Vinod Koul , Dan Williams , Per Forlin , Rabin Vincent Subject: Re: [PATCH 04/32] dmaengine: ste_dma40: Amalgamate DMA source and destination channel numbers Message-ID: <20130426142810.GD31899@gmail.com> References: <1366279934-30761-1-git-send-email-lee.jones@linaro.org> <1366279934-30761-5-git-send-email-lee.jones@linaro.org> <20130425090612.GC4623@gmail.com> <20130425132025.GM4623@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 35 On Thu, 25 Apr 2013, Linus Walleij wrote: > On Thu, Apr 25, 2013 at 3:20 PM, Lee Jones wrote: > > On Thu, 25 Apr 2013, Linus Walleij wrote: > > >> As we may want to support DEV_TO_DEV at some point. > >> > >> Then no longer, and that is not related to $SUBJECT. > > > > That's not why I'm removing it. The statement can never be true due to > > the fact that the second evaluation (src_event_group != dst_event_group) > > can never be true, which is a direct effect of 'THIS_PATCH'. > > OK that is correct, I'm fine with this then ... as part of that other > patch dealing with unreacable conditions I keep talking about... Just looking at this now. Although I agree that the "dst_event_group == STEDMA40_DEV_DST_MEMORY (-16)" issue can/should be split out prior, I don't think this "(src_event_group != dst_event_group)" should be, as it is a direct result of the code that's being changed in this patch here. It makes no sense to remove it before this patch, as it's still valid and removing it afterwards violates your break-now, fix-later stipulation. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/