From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Stephen Warren <swarren@nvidia.com>,
        Anmar Oueja <anmar.oueja@linaro.org>,
        Patrice Chotard <patrice.chotard@st.com>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] pinctrl: move subsystem mutex to pinctrl_dev struct
Date: Fri, 26 Apr 2013 16:43:32 +0200
Message-ID: <2852417.oyEN2DhaoE@wuerfel>
User-Agent: KMail/4.10.2 (Linux/3.8.0-17-generic; KDE/4.10.2; x86_64; ; )
In-Reply-To: <1366794119-766-1-git-send-email-linus.walleij@stericsson.com>
References: <1366794119-766-1-git-send-email-linus.walleij@stericsson.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1402
Lines: 37

On Wednesday 24 April 2013 11:01:59 Linus Walleij wrote:
>  /**
> - * pinctrl_lookup_state() - retrieves a state handle from a pinctrl handle
> - * @p: the pinctrl handle to retrieve the state from
> - * @name: the state name to retrieve
> + * pinctrl_select_state() - select/activate/program a pinctrl state to HW
> + * @p: the pinctrl handle for the device that requests configuration
> + * @state: the state handle to select/activate/program
>   */
> -struct pinctrl_state *pinctrl_lookup_state(struct pinctrl *p, const char *name)
> -{
> -       struct pinctrl_state *s;
> -
> -       mutex_lock(&pinctrl_mutex);
> -       s = pinctrl_lookup_state_locked(p, name);
> -       mutex_unlock(&pinctrl_mutex);
> -
> -       return s;
> -}
> -EXPORT_SYMBOL_GPL(pinctrl_lookup_state);
> -
> -static int pinctrl_select_state_locked(struct pinctrl *p,
> -                                      struct pinctrl_state *state)
> +int pinctrl_select_state(struct pinctrl *p, struct pinctrl_state *state)
>  {
>         struct p


This showed up in linux-next and broke a lot of driver modules, since you
remove the EXPORT_SYMBOL_GPL(pinctrl_lookup_state) line.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/