Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756859Ab3DZPq3 (ORCPT ); Fri, 26 Apr 2013 11:46:29 -0400 Received: from mail-da0-f44.google.com ([209.85.210.44]:44829 "EHLO mail-da0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756668Ab3DZPqZ (ORCPT ); Fri, 26 Apr 2013 11:46:25 -0400 Message-ID: <1366991182.8964.223.camel@edumazet-glaptop> Subject: RE: [RFC PATCH net-next 2/6] x86: bpf_jit_comp: support BPF_S_ANC_SECCOMP_LD_W instruction From: Eric Dumazet To: David Laight Cc: Xi Wang , Daniel Borkmann , "David S. Miller" , Russell King , Heiko Carstens , Eric Dumazet , Will Drewry , Andrew Morton , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 26 Apr 2013 08:46:22 -0700 In-Reply-To: References: <1366962706-24204-1-git-send-email-xi.wang@gmail.com> <1366962706-24204-3-git-send-email-xi.wang@gmail.com> <1366985926.8964.190.camel@edumazet-glaptop> <1366990066.8964.216.camel@edumazet-glaptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 22 On Fri, 2013-04-26 at 16:38 +0100, David Laight wrote: > The call needs the displacement from the address of > the instruction following the call. > I can't imagine any way in which above can allow for the 5 byte > 'mov imm32,%edi' instruction. > > I'd have thought there would be an EMIT1_imm32(). > (I've written a lot of x86 asm in my days!) > Thats the same. off32 is a 32bit quantity, or immediate 32 if you prefer. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/