Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756922Ab3DZPwH (ORCPT ); Fri, 26 Apr 2013 11:52:07 -0400 Received: from smtp.citrix.com ([66.165.176.89]:24403 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756113Ab3DZPwF (ORCPT ); Fri, 26 Apr 2013 11:52:05 -0400 X-IronPort-AV: E=Sophos;i="4.87,559,1363132800"; d="scan'208";a="21830888" Date: Fri, 26 Apr 2013 16:36:37 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Nicolas Pitre CC: Will Deacon , Stefano Stabellini , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "arnd@arndb.de" , "rob.herring@calxeda.com" , "linux@arm.linux.org.uk" , "olof@lixom.net" , Jon Medhurst Subject: Re: [PATCH v8 2/2] ARM: Enable selection of SMP operations at boot time In-Reply-To: Message-ID: References: <1366828819-10745-2-git-send-email-stefano.stabellini@eu.citrix.com> <20130425084933.GB12848@mudshark.cambridge.arm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1812 Lines: 42 On Thu, 25 Apr 2013, Nicolas Pitre wrote: > On Thu, 25 Apr 2013, Will Deacon wrote: > > > On Wed, Apr 24, 2013 at 07:40:19PM +0100, Stefano Stabellini wrote: > > > From: Jon Medhurst > > > > > > Add a new 'smp_init' hook to machine_desc so platforms can specify a > > > function to be used to setup smp ops instead of having a statically > > > defined value. The hook must return true when smp_ops are initialized. > > > If false the static mdesc->smp_ops will be used by default. > > > > > > Signed-off-by: Jon Medhurst > > > Signed-off-by: Nicolas Pitre > > > Signed-off-by: Stefano Stabellini > > > Reviewed-by: Santosh Shilimkar > > > --- > > > arch/arm/include/asm/mach/arch.h | 4 ++++ > > > arch/arm/kernel/setup.c | 10 ++++++---- > > > 2 files changed, 10 insertions(+), 4 deletions(-) > > > > [...] > > > > > if (is_smp()) { > > > - if (psci_smp_available()) > > > - smp_set_ops(&psci_smp_ops); > > > - else if (mdesc->smp) > > > - smp_set_ops(mdesc->smp); > > > + if (!mdesc->smp_init || !mdesc->smp_init()) { > > > > Minor nit, but this feels backwards to me. We usually return 0 on success, > > yet we're saying here that if mdesc->smp_init() returns 0, then we go and > > override the smp ops. > > It doesn't return 0, but true or false. So, semantically, if ->smp_init > returns false, that means it didn't initialize anything. In absence of other comments, I am going to leave as it is now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/