Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 27 Dec 2000 21:13:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 27 Dec 2000 21:13:27 -0500 Received: from box-26.rosh.inter.net.il ([213.8.204.26]:9220 "EHLO callisto.yi.org") by vger.kernel.org with ESMTP id ; Wed, 27 Dec 2000 21:13:21 -0500 Date: Thu, 28 Dec 2000 03:41:05 +0200 (IST) From: Dan Aloni To: Philipp Rumpf cc: Linus Torvalds , Rik van Riel , Zlatko Calusic , "Marco d'Itri" , Alan Cox , Alexander Viro , linux-kernel Subject: Re: innd mmap bug in 2.4.0-test12 In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Dec 2000, Dan Aloni wrote: > On Wed, 27 Dec 2000, Philipp Rumpf wrote: > > > On Wed, Dec 27, 2000 at 03:41:04PM -0800, Linus Torvalds wrote: > > > It must be wrong. > > > > > > If we have a dirty page on the LRU lists, that page _must_ have a mapping. > > > > What about pages with a mapping but without a writepage function ? or pages > > whose writepage function fails ? The current code seems to simply put the > > page onto the active list in that case, which seems just as wrong to me. > > I noticed the offset of 'mapping' in struct page doesn't match the offset > which get resolved at obsolute address 0x0000000c according to the Oops, > but it does matches the offset of a_ops in struct address_space, which > makes me wonder if it's possible that a_ops == NULL. Suggestions? I was confused, or maybe temporal insanity, ignore that ;-) -- Dan Aloni dax@karrde.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/