Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932292Ab3DZSkL (ORCPT ); Fri, 26 Apr 2013 14:40:11 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:49498 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752079Ab3DZSkI (ORCPT ); Fri, 26 Apr 2013 14:40:08 -0400 Message-ID: <1367001606.8964.246.camel@edumazet-glaptop> Subject: Re: [RFC PATCH net-next 2/6] x86: bpf_jit_comp: support BPF_S_ANC_SECCOMP_LD_W instruction From: Eric Dumazet To: Xi Wang Cc: Daniel Borkmann , "David S. Miller" , Russell King , Heiko Carstens , Eric Dumazet , Will Drewry , Andrew Morton , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 26 Apr 2013 11:40:06 -0700 In-Reply-To: References: <1366962706-24204-1-git-send-email-xi.wang@gmail.com> <1366962706-24204-3-git-send-email-xi.wang@gmail.com> <1366985926.8964.190.camel@edumazet-glaptop> <1366989094.8964.212.camel@edumazet-glaptop> <1366992840.8964.239.camel@edumazet-glaptop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 24 On Fri, 2013-04-26 at 14:25 -0400, Xi Wang wrote: > Not sure how many you are speaking for when you say "We are very dumb". :) > > Thanks for catching this. I'l remove this arch thing in v2. > > To address your other concern about registers, I'll add some comments > to the code, something like: > > "%rdi,%r8,%r9 are not used by seccomp filters; it's safe to not save them." OK good BTW, most of us prefer Bottom posting on lkml/netdev http://en.wikipedia.org/wiki/Posting_style#Bottom-posting Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/