Date: Sat, 27 Apr 2013 09:19:06 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>, Christoph Lameter <cl@linux.com>,
        Hakan Akkan <hakanakkan@gmail.com>, Kevin Hilman <khilman@linaro.org>,
        Li Zhong <zhong@linux.vnet.ibm.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] nohz: Select VIRT_CPU_ACCOUNTING_GEN from full
 dynticks config
Message-ID: <20130427071906.GA15172@gmail.com>
References: <1366988007-30665-1-git-send-email-fweisbec@gmail.com>
 <1366988007-30665-2-git-send-email-fweisbec@gmail.com>
 <20130426153956.GB3860@linux.vnet.ibm.com>
 <20130426162214.GB30716@somewhere>
 <CAFTL4hxe8Rwj7sqo0G_xPisvXB_tMhVSdD+z32aQnJM9A=31WQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFTL4hxe8Rwj7sqo0G_xPisvXB_tMhVSdD+z32aQnJM9A=31WQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1473
Lines: 39


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> 2013/4/26 Frederic Weisbecker <fweisbec@gmail.com>:
> > On Fri, Apr 26, 2013 at 08:39:56AM -0700, Paul E. McKenney wrote:
> >> >  config VIRT_CPU_ACCOUNTING_GEN
> >> >     bool "Full dynticks CPU time accounting"
> >> > -   depends on HAVE_CONTEXT_TRACKING && 64BIT
> >> > +   depends on HAVE_CONTEXT_TRACKING && 64BIT && NO_HZ_FULL
> >>
> >> Do you really want this change?  This prohibits VIRT_CPU_ACCOUNTING_GEN
> >> unless NO_HZ_FULL, which means that it can no longer be used in situations
> >> where it used to be usable.  My guess is that you want to leave this
> >> particular line as it was.
> >
> > Hmm, this can make sense. This can be used to perform comparisons between
> > tick-based and tickless cputime accounting easily.
> >
> > I'll respin.
> 
> So Ingo please pull "timers/nohz-v2" instead. It does the same but
> keeps VIRT_CPU_ACCOUNTING_GEN available even without full dynticks
> (could be useful when users need something more precise than tick
> based cputime accounting.)
> 
> HEAD is 8c23b80ec7f1f5405f07bb56c2f8378800ecf401
> 
> If you've already pulled the previous branch I'll make a delta instead.
> 
> Thanks.

Pulled, thanks Frederic!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/