Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173Ab3D1I4n (ORCPT ); Sun, 28 Apr 2013 04:56:43 -0400 Received: from mail-ea0-f173.google.com ([209.85.215.173]:61387 "EHLO mail-ea0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851Ab3D1I4l (ORCPT ); Sun, 28 Apr 2013 04:56:41 -0400 Message-ID: <517CE43C.3080003@gmail.com> Date: Sun, 28 Apr 2013 10:56:28 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Marek Belisko CC: mturquette@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, zonque@gmail.com, Marek Belisko Subject: Re: [PATCH 1/2] clk: si5351: Fix clkout rate computation. References: <1366698170-31346-1-git-send-email-marek.belisko@streamunlimited.com> In-Reply-To: <1366698170-31346-1-git-send-email-marek.belisko@streamunlimited.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 34 On 04/23/2013 08:22 AM, Marek Belisko wrote: > Rate was incorrectly computed because we read from wrong divider register. > > Signed-off-by: Marek Belisko Marek, sorry for the late reply and very good catch! Acked-by: Sebastian Hesselbarth > --- > drivers/clk/clk-si5351.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c > index 8927284..cf39e53 100644 > --- a/drivers/clk/clk-si5351.c > +++ b/drivers/clk/clk-si5351.c > @@ -932,7 +932,7 @@ static unsigned long si5351_clkout_recalc_rate(struct clk_hw *hw, > unsigned char reg; > unsigned char rdiv; > > - if (hwdata->num> 5) > + if (hwdata->num<= 5) > reg = si5351_msynth_params_address(hwdata->num) + 2; > else > reg = SI5351_CLK6_7_OUTPUT_DIVIDER; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/