Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756549Ab3D1WMJ (ORCPT ); Sun, 28 Apr 2013 18:12:09 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:57847 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753722Ab3D1WMH (ORCPT ); Sun, 28 Apr 2013 18:12:07 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 29 Apr 2013 00:12:05 +0200 Message-ID: Subject: Re: [PATCH] UBI: fix memory leak when use fastmap From: richard -rw- weinberger To: wang.bo116@zte.com.cn Cc: artem.bityutskiy@linux.intel.com, "linux-mtd@lists.infradead.org" , LKML , liu.dong3@zte.com.cn, cui.yunfeng@zte.com.cn Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 27 Hi! On Tue, Apr 16, 2013 at 10:53 AM, wrote: > Hello, > Sorry, there is still something wrong with the previous patch's > format, try to submit it again. When use ubi fastmap, there is a memory > leak which will make destroy_ai() fail to free the slab alloced in > scan_fast(). The following patch fix this problem by use a temporary > "ubi_attach_info" variable in scan_fast(). Thanks a lot for your patch! Did you test it well? We need to make sure that it does the right thing for the following cases: 1. fastmap disabled, attaching a non-fastmap volume 1. fastmap disabled, attaching a fastmap volume 3. fastmap enabled, attaching a non-fastmap volume 4. fastmap enablled, attaching a fastmap volume -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/