Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757893Ab3D2KHi (ORCPT ); Mon, 29 Apr 2013 06:07:38 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:35797 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757502Ab3D2KHf (ORCPT ); Mon, 29 Apr 2013 06:07:35 -0400 Subject: Re: [PATCH 1/2] acpi: video: add function to support unregister backlight From: joeyli To: Aaron Lu Cc: mjg@redhat.com, rjw@sisk.pl, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Carlos Corbacho , Dmitry Torokhov , Corentin Chary , Thomas Renninger In-Reply-To: <517A0FA1.3040406@intel.com> References: <1366634355-26482-1-git-send-email-jlee@suse.com> <1366634355-26482-2-git-send-email-jlee@suse.com> <517A0FA1.3040406@intel.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 29 Apr 2013 18:06:06 +0800 Message-ID: <1367229966.22858.52.camel@linux-s257.site> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2986 Lines: 84 於 五，2013-04-26 於 13:24 +0800，Aaron Lu 提到： > On 04/22/2013 08:39 PM, Chun-Yi Lee wrote: > > From: "Lee, Chun-Yi" > > > > There have situation we unregister whole acpi/video driver by downstream driver > > just want to remove backlight control interface of acpi/video. It caues we lost > > other functions of acpi/video, e.g. transfer acpi event to input event. > > > > So, this patch add a new function, find_video_unregister_backlight, it provide > > the interface let downstream driver can tell acpi/video to unregister backlight > > interface of all acpi video devices. Then we can keep functions of acpi/video > > but only remove backlight support. > > > > Reference: bko#35622 > > https://bugzilla.kernel.org/show_bug.cgi?id=35622 > > > > Tested-by: Andrzej Krentosz > > Cc: Carlos Corbacho > > Cc: Matthew Garrett > > Cc: Dmitry Torokhov > > Cc: Corentin Chary > > Cc: Rafael J. Wysocki > > Cc: Aaron Lu > > Cc: Thomas Renninger > > Signed-off-by: Lee, Chun-Yi > > --- > > drivers/acpi/video.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > > include/acpi/video.h | 2 ++ > > 2 files changed, 48 insertions(+) > > > > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c > > index 313f959..acd2e7a 100644 > > --- a/drivers/acpi/video.c > > +++ b/drivers/acpi/video.c > > @@ -1793,6 +1793,52 @@ static int __init intel_opregion_present(void) > > return opregion; > > } > > > > +static acpi_status > > +find_video_unregister_backlight(acpi_handle handle, u32 lvl, void *context, > > + void **rv) > > +{ > > + struct acpi_device *acpi_dev; > > + struct acpi_video_bus *video = NULL; > > + struct acpi_video_device *dev, *next; > > + > > + if (acpi_bus_get_device(handle, &acpi_dev)) > > + return AE_OK; > > + > > + if (!acpi_match_device_ids(acpi_dev, video_device_ids)) { > > + video = acpi_driver_data(acpi_dev); > > + acpi_video_bus_stop_devices(video); > > + mutex_lock(&video->device_list_lock); > > + list_for_each_entry_safe(dev, next, &video->video_device_list, > > + entry) { > > + if (dev->backlight) { > > + backlight_device_unregister(dev->backlight); > > + dev->backlight = NULL; > > + kfree(dev->brightness->levels); > > + kfree(dev->brightness); > > + } > > The cooling_dev should also be unregistered I think. > > Thanks, > Aaron > Yes, you are right! Unregistering backlight interface of video devices means the backlight control functions broken, so it can not used for throttling. I will unregister cooling_dev in v2 patch. Thanks a lot! Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/