Message-ID: <1367235801.4656.66.camel@marge.simpson.net>
Subject: Re: perf: report loops endlessly if record was killed via SIGTERM
From: Mike Galbraith <bitbucket@online.de>
To: David Ahern <dsahern@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Arnaldo Carvalho de Melo <acme@infradead.org>
Date: Mon, 29 Apr 2013 13:43:21 +0200
In-Reply-To: <517E5905.1070700@gmail.com>
References: <1367222415.4656.61.camel@marge.simpson.net>
	 <517E5905.1070700@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 694
Lines: 18

On Mon, 2013-04-29 at 07:27 -0400, David Ahern wrote: 
> On 4/29/13 4:00 AM, Mike Galbraith wrote:
> > Say SIGINT instead,
> > and it works as expected.  SIGTERM leaves perf.data in a bad state that
> > report can't deal with, but it'll happily keep trying forever.
> 
> header is usually updated on_exit which requires a clean exit. perhaps 
> we should add SIGTERM to the signal list.

Yeah.  Graceful exit, and idiot proofing for free :)

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/