Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758547Ab3D2QrW (ORCPT ); Mon, 29 Apr 2013 12:47:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12439 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757677Ab3D2QrV (ORCPT ); Mon, 29 Apr 2013 12:47:21 -0400 Subject: Re: linux-next: build failure after merge of the nfsd tree From: Simo Sorce To: Chuck Lever Cc: "J. Bruce Fields" , Stephen Rothwell , linux-next@vger.kernel.org, Linux Kernel Mailing List , Trond Myklebust In-Reply-To: <261DE171-B758-4211-AA10-AA67E9E6619B@oracle.com> References: <20130429112434.dcc80cfce804beeacc68793a@canb.auug.org.au> <20130429154541.GI17268@fieldses.org> <09A69F90-5D9A-4AF6-9B7D-CC1D74A237EA@oracle.com> <1367252960.10084.491.camel@willson.li.ssimo.org> <261DE171-B758-4211-AA10-AA67E9E6619B@oracle.com> Content-Type: text/plain; charset="UTF-8" Organization: Red Hat, Inc. Date: Mon, 29 Apr 2013 12:46:59 -0400 Message-ID: <1367254019.10084.494.camel@willson.li.ssimo.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2553 Lines: 59 On Mon, 2013-04-29 at 12:37 -0400, Chuck Lever wrote: > On Apr 29, 2013, at 12:29 PM, Simo Sorce wrote: > > > On Mon, 2013-04-29 at 12:05 -0400, Chuck Lever wrote: > >> On Apr 29, 2013, at 11:45 AM, "J. Bruce Fields" wrote: > >> > >>> On Mon, Apr 29, 2013 at 10:53:37AM -0400, Chuck Lever wrote: > >>>> > >>>> On Apr 28, 2013, at 9:24 PM, Stephen Rothwell wrote: > >>>> > >>>>> Hi J., > >>>>> > >>>>> After merging the nfsd tree, today's linux-next build (powerpc > >>>>> ppc64_defconfig) failed like this: > >>>>> > >>>>> net/sunrpc/auth_gss/svcauth_gss.c: In function 'gss_proxy_save_rsc': > >>>>> net/sunrpc/auth_gss/svcauth_gss.c:1182:3: error: implicit declaration of function 'gss_mech_get_by_OID' [-Werror=implicit-function-declaration] > >>>>> > >>>>> Caused byc ommit 030d794bf498 ("SUNRPC: Use gssproxy upcall for server > >>>>> RPCGSS authentication"). gss_mech_get_by_OID() made static to > >>>>> net/sunrpc/auth_gss/gss_mech_switch.c by commit 9568c5e9a61d ("SUNRPC: > >>>>> Introduce rpcauth_get_pseudoflavor()") in the nfs tree (part of the nfs > >>>>> tree that you did not merge). > >>>>> > >>>>> I don't know how to fix this, so I have used the nfsd tree from > >>>>> next-20130426 for today. > >>>> > >>>> Bruce, it might make sense for me to submit the three server-side RPC GSS patches, and then you can rebase the gssproxy work on top of those. Let me know how you would like to proceed. > >>> > >>> I'm happy to take those patches whenever you consider them ready. Would > >>> that fix the problem? > >> > >> Someone would need to modify the gssproxy patches to use the new interfaces. > >> > >>> Also: it looks like 030d794bf498 "SUNRPC: Introduce > >>> rpcauth_get_pseudoflavor()" is in Trond's linux-next, but not his > >>> nfs-for-next. I'm not sure what that means--is it safe to rebase on top > >>> of *that*? > >> > >> That doesn't seem right to me. > > > > GSS-Proxy patches are 1 year old and we've been delayed once already to > > accomodate the containers work, maybe it's time for your patches to be > > rebased on gssproxy ones ? :-) > > Don't sweat it. IMO this is a simple merge problem, unlike the containers work. Glad to hear that. Simo. -- Simo Sorce * Red Hat, Inc * New York -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/