Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751236Ab3D2Rwc (ORCPT ); Mon, 29 Apr 2013 13:52:32 -0400 Received: from mail-we0-f172.google.com ([74.125.82.172]:57311 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758636Ab3D2Ruq (ORCPT ); Mon, 29 Apr 2013 13:50:46 -0400 MIME-Version: 1.0 In-Reply-To: <1696679.tiFHy28fsU@avalon> References: <1366963535-15963-1-git-send-email-prabhakar.csengg@gmail.com> <32556864.ElKWl0cdN2@avalon> <1696679.tiFHy28fsU@avalon> From: Prabhakar Lad Date: Mon, 29 Apr 2013 23:20:24 +0530 Message-ID: Subject: Re: [PATCH] media: i2c: tvp7002: enable TVP7002 decoder for media controller based usage To: Laurent Pinchart Cc: LMML , LKML , Mauro Carvalho Chehab , Hans Verkuil , Guennadi Liakhovetski , DLOS Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1955 Lines: 52 Hi Laurent, On Mon, Apr 29, 2013 at 11:06 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Monday 29 April 2013 23:00:26 Prabhakar Lad wrote: >> On Mon, Apr 29, 2013 at 7:57 PM, Laurent Pinchart wrote: >> > On Friday 26 April 2013 13:35:35 Prabhakar Lad wrote: >> >> From: Lad, Prabhakar >> >> >> >> This patch enables tvp7002 decoder driver for media controller >> >> based usage by adding v4l2_subdev_pad_ops operations support >> >> for enum_mbus_code, set_pad_format, get_pad_format and >> >> media_entity_init() >> >> on probe and media_entity_cleanup() on remove. >> >> >> >> The device supports 1 output pad and no input pads. >> > >> > We should actually define input pads, connected to connector entities, but >> > that's out of scope for this patch. >> > >> >> Signed-off-by: Lad, Prabhakar >> >> --- > [snip] >> >> +/* media pad related operation handlers */ >> >> +static const struct v4l2_subdev_pad_ops tvp7002_pad_ops = { >> >> + .enum_mbus_code = tvp7002_enum_mbus_code, >> >> + .get_fmt = tvp7002_get_pad_format, >> >> + .set_fmt = tvp7002_set_pad_format, >> > >> > We will need to define pad-aware DV timings operations. >> >> I didn't get you this? > > We will need to extend the pad operations (struct v4l2_subdev_pad_ops) with > operations to enumerate, get and set DV timings at the pad level. > not sure if exposing get and set DV timings at the pad level would be a better idea, timings for pad's would be the same always and anyways we get DV timings on video node. I cant think of usecase where we require get and set DV timings at the pad level. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/