Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932688Ab3D2VcC (ORCPT ); Mon, 29 Apr 2013 17:32:02 -0400 Received: from mail-vb0-f51.google.com ([209.85.212.51]:64473 "EHLO mail-vb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932595Ab3D2VcA (ORCPT ); Mon, 29 Apr 2013 17:32:00 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 29 Apr 2013 14:31:59 -0700 X-Google-Sender-Auth: EL2AoCs8P33Vg0UnFKgYPqBXz4Q Message-ID: Subject: Re: [GIT PATCH] USB patches for 3.10-rc1 From: Linus Torvalds To: Alan Stern Cc: Greg KH , Andrew Morton , Linux Kernel Mailing List , USB list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 33 On Mon, Apr 29, 2013 at 2:14 PM, Alan Stern wrote: > > What other things seemed odd about Greg's pull request? The only other thing I noticed was the new CONFIG_USB_PHY quesiton, which is not something that I think is sensible to ask from a user, and the help text doesn't really help anything either. I think the question may make sense, but the wording does not. *EVERYBODY* wants a USB PHY. You can't have USB without a physical layer unless it's a purely virtual device. There's one in a EHCI controller too. It's like a network chip - without a PHY there's no point. Why ask about whether you want to support a phy or not? The question makes no sense. So I don't think the question should be "do you want a USB PHY". The question should be "Do you want a driver for some of the specialized external USB controllers" or something like that. Because as it is now, anybody who actually reads the question is likely to answer "y", I think, even if he just wants one of the *normal* USB chips that don't split out the PHY. Hmm? Or does PHY have some magic other meaning in USB circles? In which case the wording should still be totally redone to not be so confusing and misleading. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/