Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758841Ab3D3HP3 (ORCPT ); Tue, 30 Apr 2013 03:15:29 -0400 Received: from mga11.intel.com ([192.55.52.93]:26116 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754112Ab3D3HP2 (ORCPT ); Tue, 30 Apr 2013 03:15:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,579,1363158000"; d="scan'208";a="329962171" Date: Tue, 30 Apr 2013 00:21:47 -0700 From: Bin Gao To: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Jacob Pan , Jesse Barnes , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org Subject: x86/pci/mrst: force all pci config toward 0:0:0, 0:2:0 and 0:3:0 to type 1 Message-ID: <20130430072147.GA37866@bingao-desk1.fm.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1689 Lines: 48 x86/pci/mrst: force all pci config access toward 0:0:0, 0:2:0 and 0:3:0 to type 1 For real pci devices 0:0:0, 0:2:0 and 0:3:0, there is either no pci shim, or no guarantee of data correctness of offset 256-4k. So for whatever reason, Linux kernel should not do MMCFG pci config access to those devices. Instead, always use type 1 for those devices. Signed-off-by: Bin Gao --- arch/x86/pci/mrst.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/x86/pci/mrst.c b/arch/x86/pci/mrst.c index 6eb18c4..0e0fabf 100644 --- a/arch/x86/pci/mrst.c +++ b/arch/x86/pci/mrst.c @@ -141,6 +141,11 @@ static int pci_device_update_fixed(struct pci_bus *bus, unsigned int devfn, */ static bool type1_access_ok(unsigned int bus, unsigned int devfn, int reg) { + if (bus == 0 && (devfn == PCI_DEVFN(2, 0) + || devfn == PCI_DEVFN(0, 0) + || devfn == PCI_DEVFN(3, 0))) + return 1; + /* This is a workaround for A0 LNC bug where PCI status register does * not have new CAP bit set. can not be written by SW either. * @@ -150,10 +155,7 @@ static bool type1_access_ok(unsigned int bus, unsigned int devfn, int reg) */ if (reg >= 0x100 || reg == PCI_STATUS || reg == PCI_HEADER_TYPE) return 0; - if (bus == 0 && (devfn == PCI_DEVFN(2, 0) - || devfn == PCI_DEVFN(0, 0) - || devfn == PCI_DEVFN(3, 0))) - return 1; + return 0; /* langwell on others */ } -- 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/