Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760285Ab3D3Lw5 (ORCPT ); Tue, 30 Apr 2013 07:52:57 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:50666 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759401Ab3D3Lw4 (ORCPT ); Tue, 30 Apr 2013 07:52:56 -0400 From: "Rafael J. Wysocki" To: Greg Kroah-Hartman Cc: Toshi Kani , ACPI Devel Maling List , LKML , isimatu.yasuaki@jp.fujitsu.com, vasilis.liaskovitis@profitbricks.com Subject: Re: [PATCH 2/3 RFC] Driver core: Use generic offline/online for CPU offline/online Date: Tue, 30 Apr 2013 14:01:10 +0200 Message-ID: <18234756.omYDfXWPpx@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.9.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <20130429231106.GC1333@kroah.com> References: <1576321.HU0tZ4cGWk@vostro.rjw.lan> <5608485.T3GFgtNYov@vostro.rjw.lan> <20130429231106.GC1333@kroah.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 39 On Monday, April 29, 2013 04:11:06 PM Greg Kroah-Hartman wrote: > On Mon, Apr 29, 2013 at 02:28:02PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Rework the CPU hotplug code in drivers/base/cpu.c to use the > > generic offline/online support introduced previously instead of > > its own CPU-specific code. > > > > For this purpose, modify cpu_subsys to provide offline and online > > callbacks for CONFIG_HOTPLUG_CPU set and remove the code handling > > the CPU-specific 'online' sysfs attribute. > > > > This modification is not supposed to change the user-observable > > behavior of the kernel (i.e. the 'online' attribute will be present > > in exactly the same place in sysfs and should trigger exactly the > > same actions as before). > > > > Signed-off-by: Rafael J. Wysocki > > --- > > drivers/base/cpu.c | 62 ++++++++++++----------------------------------------- > > 1 file changed, 15 insertions(+), 47 deletions(-) > > Very nice, I like reductions like this :) Thanks! So I guess the patches make sense to you overall? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/