Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932291Ab3D3O2d (ORCPT ); Tue, 30 Apr 2013 10:28:33 -0400 Received: from mail-ve0-f171.google.com ([209.85.128.171]:59796 "EHLO mail-ve0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932192Ab3D3O2Y (ORCPT ); Tue, 30 Apr 2013 10:28:24 -0400 MIME-Version: 1.0 In-Reply-To: <1367281038.30667.43.camel@gandalf.local.home> References: <20130429195100.202681236@goodmis.org> <1367280494.30667.38.camel@gandalf.local.home> <1367281038.30667.43.camel@gandalf.local.home> Date: Tue, 30 Apr 2013 07:28:22 -0700 X-Google-Sender-Auth: cNphZI2DcHnYcZ8pnByxyTina_k Message-ID: Subject: Re: [PATCH 0/2] [GIT PULL] localmodconfig: Fix missing depends of config files included in if statements From: Linus Torvalds To: Steven Rostedt Cc: Linux Kernel Mailing List , Linux Kbuild mailing list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1892 Lines: 38 On Mon, Apr 29, 2013 at 5:17 PM, Steven Rostedt wrote: > > BTW, what's the preferred method for this. I already posted a lot of > work to linux-next when I found bugs that required going into your tree. > I backported the fixes knowing that it will cause conflicts when you > merge. > > IIRC, you stated that you don't mind doing conflict resolutions > yourself, so I did not try to fix it a head of time, as the conflicts > were rather minor. > > Should I have merged your tree and done the conflict resolutions myself, > or was it OK to do what I did, and let you do the conflict resolution > and send you any fixes that needed to be done afterward? You did the right thing. In general, if you know there will be conflicts, it's nice if you mention then in the pull request, but for simple stuff like this it's really not a big deal. The fact that I screwed up and then missed a "!" when editing it all is embarrassing, but it wasn't because the conflict was really *complicated*, it was just stupid editing error. If the conflicts are really complex, at some point I really enjoy getting a "here's a pre-merged branch if you prefer it", and if people send that, I still tend to do the merge myself, but then I often just compare against the pre-merged one afterwards to verify. But that's actually extra work, so I'd suggest doing that only for things that really warrant it. It's generally a bad thing if it happens, because it means that we had some bad workflow and people stepped on each others toes (or we had unlucky backports etc that ended up being in the same area as much more work). Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/