Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761019Ab3D3QRS (ORCPT ); Tue, 30 Apr 2013 12:17:18 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:56360 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760962Ab3D3QRN (ORCPT ); Tue, 30 Apr 2013 12:17:13 -0400 Date: Tue, 30 Apr 2013 09:17:11 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: =?UTF-8?Q?Vincent_Stehl=C3=A9?= cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] memory hotplug: fix warnings In-Reply-To: <1367310697-6332-1-git-send-email-vincent.stehle@laposte.net> Message-ID: References: <1367310697-6332-1-git-send-email-vincent.stehle@laposte.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="531381512-888928222-1367338632=:10368" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 30 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --531381512-888928222-1367338632=:10368 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 30 Apr 2013, Vincent Stehlé wrote: > diff --git a/include/linux/memory.h b/include/linux/memory.h > index 73817af..85c31a8 100644 > --- a/include/linux/memory.h > +++ b/include/linux/memory.h > @@ -137,7 +137,7 @@ enum mem_add_context { BOOT, HOTPLUG }; > #define register_hotmemory_notifier(nb) register_memory_notifier(nb) > #define unregister_hotmemory_notifier(nb) unregister_memory_notifier(nb) > #else > -#define hotplug_memory_notifier(fn, pri) (0) > +#define hotplug_memory_notifier(fn, pri) ({ 0; }) > /* These aren't inline functions due to a GCC bug. */ > #define register_hotmemory_notifier(nb) ({ (void)(nb); 0; }) > #define unregister_hotmemory_notifier(nb) ({ (void)(nb); }) You can't use the standard do {} while (0)? --531381512-888928222-1367338632=:10368-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/