Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760871Ab3D3Rsi (ORCPT ); Tue, 30 Apr 2013 13:48:38 -0400 Received: from mga09.intel.com ([134.134.136.24]:39569 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760806Ab3D3Rsg (ORCPT ); Tue, 30 Apr 2013 13:48:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,582,1363158000"; d="scan'208";a="305742840" Subject: Re: [PATCH 1/2] Make the batch size of the percpu_counter configurable From: Tim Chen To: Christoph Lameter Cc: Andrew Morton , Tejun Heo , Al Viro , Dave Hansen , Andi Kleen , linux-kernel , linux-mm In-Reply-To: <0000013e5bfd1548-a6ef7962-7b00-495b-8e83-d7a08413e165-000000@email.amazonses.com> References: <0000013e5b24d2c5-9b899862-e2fd-4413-8094-4f1e5a0c0f62-000000@email.amazonses.com> <1367339009.27102.174.camel@schen9-DESK> <0000013e5bfd1548-a6ef7962-7b00-495b-8e83-d7a08413e165-000000@email.amazonses.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 30 Apr 2013 10:48:14 -0700 Message-ID: <1367344094.27102.182.camel@schen9-DESK> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-1.fc14) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1777 Lines: 45 On Tue, 2013-04-30 at 17:28 +0000, Christoph Lameter wrote: > On Tue, 30 Apr 2013, Tim Chen wrote: > > > On Tue, 2013-04-30 at 13:32 +0000, Christoph Lameter wrote: > > > On Mon, 29 Apr 2013, Tim Chen wrote: > > > > > > > diff --git a/include/linux/percpu_counter.h b/include/linux/percpu_counter.h > > > > index d5dd465..5ca7df5 100644 > > > > --- a/include/linux/percpu_counter.h > > > > +++ b/include/linux/percpu_counter.h > > > > @@ -22,6 +22,7 @@ struct percpu_counter { > > > > struct list_head list; /* All percpu_counters are on a list */ > > > > #endif > > > > s32 __percpu *counters; > > > > + int *batch ____cacheline_aligned_in_smp; > > > > }; > > > > > > What is this for and why does it have that alignmend? > > > > I was assuming that if batch is frequently referenced, it probably > > should not share a cache line with the counters field. > > And why is it a pointer? A pointer because the default percpu_counter_batch value could change later when cpus come online after we initialize per cpu counter and percpu_counter_batch will get computed again in percpu_counter_startup. Making it a pointer will make it unnecessary to come back and change the batch sizes if we use static batch value and default batch size. > > And the pointer is so frequently changed that it needs it own cache line? > On second thought, your're right. It is unnecessary for *batch to have its own cache line as the counters pointer and head_list above it will not change frequently. I'll remove the cache alignment. Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/