Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761275Ab3D3Sal (ORCPT ); Tue, 30 Apr 2013 14:30:41 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:45256 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760855Ab3D3Saj (ORCPT ); Tue, 30 Apr 2013 14:30:39 -0400 Date: Tue, 30 Apr 2013 19:30:35 +0100 From: Mark Brown To: Fabio Baltieri Cc: Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij , Lee Jones , Ola Lilja Message-ID: <20130430183035.GC26160@sirena.org.uk> References: <1367330994-7259-1-git-send-email-fabio.baltieri@linaro.org> <1367330994-7259-3-git-send-email-fabio.baltieri@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5QAgd0e35j3NYeGe" Content-Disposition: inline In-Reply-To: <1367330994-7259-3-git-send-email-fabio.baltieri@linaro.org> X-Cookie: Be different: conform. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 82.42.102.178 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/3] ASoC: ux500: move clock controls to ab8500-codec X-SA-Exim-Version: 4.2.1 (built Mon, 22 Mar 2010 06:51:10 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2292 Lines: 57 --5QAgd0e35j3NYeGe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 30, 2013 at 04:09:53PM +0200, Fabio Baltieri wrote: > Move ab8500 clock control definitions to the ab8500 codec driver, > leaving only card specific setting in mop500_ab8500_ctrls. So, if this is some generic thing and not some weird stuff for the card this really reopens the question about why this is done with user visible controls... > static struct snd_kcontrol_new ab8500_ctrls[] = { > + /* Digital interface - Clocks */ > + SOC_SINGLE("Digital Interface Master Generator Switch", > + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENMASTGEN, > + 1, 0), > + SOC_SINGLE("Digital Interface 0 Bit-clock Switch", > + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK0, > + 1, 0), > + SOC_SINGLE("Digital Interface 1 Bit-clock Switch", > + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK1, > + 1, 0), ...this is all stuff that is normally figured out automatically by the drivers, we know when the audio interface is in use and hence when it needs to be clocked. --5QAgd0e35j3NYeGe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRgA3IAAoJELSic+t+oim9x1QP/iiEmShnYvFGkVpqah3NZPzg Y5qvxDDXFlFNMd3vD9woe/FwLrMivmNcS4lOlHqNb307Q1mepHggcztia5ZPHTC5 M19x2S2vzXrshGUp8GPnY3Mi/j72Ae9cT4/B4JUiL+w69fSjLsHrri37ujs2aazf /G9/92BWB3gaV4ZtyyIP3EyIWre4sTIyiBB0iRKt+wSZ8XQ0zo8mZWzcj+dVxW6D DxRG8RPvEZ4XpBZzEykzKs0qQYTOFfuAX/z2DB7DogKiB4YmiNc0MlMicwUnHt1f S5XN3GZFCaLQFM7Yc8zHVaLjQhOFyP+SVTS6lzoVuFOHUSeQqcH2Uwi/WNOWGVkP lNiyEARIguVwRnA6A++TIzKTqTYDbnTvDhmWtEkVb+b0bfBTJc7fWwEBDbr7WFIO q5CB8UimA7+nSrJHSMRMhBqpphZWqjWoBSqJ9qdvS6ZG5ECTOxMkqzbOVFoLGpAR h4OM4tpJDDOdgZyqZBef9D2rcwXTBKffQiMtADkfy7wjMGuP8JOGjK3liPrGzmik 35ZrmV3hXKYDJG7/nyyA/q0izMSwekEkAEERp7iOO/ey5Org7d+vkot9aoE2uVNc WESxLocuKWGM+9Gej+NCpvmFMSyp5pwy8UHa5KLVhI+dQC6vInRYeJWrVQ+rs5wl GZAYlhYXWKccpi/2qp8I =4Lf8 -----END PGP SIGNATURE----- --5QAgd0e35j3NYeGe-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/