Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933988Ab3EAAXd (ORCPT ); Tue, 30 Apr 2013 20:23:33 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:56410 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934129Ab3EAAXY (ORCPT ); Tue, 30 Apr 2013 20:23:24 -0400 Date: Tue, 30 Apr 2013 17:23:21 -0700 From: Greg Kroah-Hartman To: =?iso-8859-1?Q?S=F6ren?= Brinkmann Cc: Michal Simek , Josh Cartwright , Mike Turquette , Lars-Peter Clausen , Peter Crosthwaite , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Russell King , Stephen Warren , Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [PATCH 1/7] tty: xuartps: Sort #includes alphabetically Message-ID: <20130501002321.GB7435@kroah.com> References: <1367366284-28304-1-git-send-email-soren.brinkmann@xilinx.com> <1367366284-28304-2-git-send-email-soren.brinkmann@xilinx.com> <20130501000048.GA1840@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 23 On Tue, Apr 30, 2013 at 05:05:40PM -0700, S?ren Brinkmann wrote: > On Tue, Apr 30, 2013 at 05:00:48PM -0700, Greg Kroah-Hartman wrote: > > On Tue, Apr 30, 2013 at 04:57:58PM -0700, Soren Brinkmann wrote: > > > Signed-off-by: Soren Brinkmann > > > CC: Greg Kroah-Hartman > > > CC: Jiri Slaby > > > CC: linux-serial@vger.kernel.org > > > > Why would you need/want to do this? > I often come across duplicated includes. Having some kind of order helps > avoiding that, imho. We have a tool to handle duplicated includes, no need to put them in sorted order for them to be detected. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/