From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@elte.hu, eranian@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf, x86: Add workaround for MEM_*_RETIRED errata BV98
References: <1367261108-9567-1-git-send-email-andi@firstfloor.org>
	<20130501090718.GA28253@dyad.programming.kicks-ass.net>
Date: Wed, 01 May 2013 02:56:32 -0700
In-Reply-To: <20130501090718.GA28253@dyad.programming.kicks-ass.net> (Peter
	Zijlstra's message of "Wed, 1 May 2013 11:07:19 +0200")
Message-ID: <m261z3uipb.fsf@firstfloor.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1040
Lines: 29

Peter Zijlstra <peterz@infradead.org> writes:
>
> So you're saying that if two SMT siblings count the same MEM_*_RETIRED event
> (on the same counter?) events can get accounted to the wrong sibling?

It can happen regardless of what event is enabled on the other counter.

> And when the other sibling doesn't have (the same counter?) enabled we
> can loose events?

doesn't have any events enabled.

> This begs the question what happens when the sibling does have the (same?)
> counter enabled but counting an all together different event; do we then still
> 'loose' events from the one sibling and add then to the other counter?

Yes, that is what the patch fixes.

Of course only if you actually apply it, and not lose it as usual.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/