Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761288Ab3EAL4A (ORCPT ); Wed, 1 May 2013 07:56:00 -0400 Received: from mail-ee0-f41.google.com ([74.125.83.41]:38870 "EHLO mail-ee0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755794Ab3EALzx (ORCPT ); Wed, 1 May 2013 07:55:53 -0400 Date: Wed, 1 May 2013 13:55:49 +0200 From: Ingo Molnar To: Andi Kleen Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, stable@vger.kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 1/2] Fix perf LBR filtering Message-ID: <20130501115549.GA19811@gmail.com> References: <1366844694-2770-1-git-send-email-andi@firstfloor.org> <20130425162535.GA5828@dyad.programming.kicks-ass.net> <20130425164100.GC16732@two.firstfloor.org> <20130425164837.GD5828@dyad.programming.kicks-ass.net> <20130425170037.GD16732@two.firstfloor.org> <20130425171842.GA8669@dyad.programming.kicks-ass.net> <20130425174211.GE16732@two.firstfloor.org> <20130426075601.GB8669@dyad.programming.kicks-ass.net> <20130426194633.GF16732@two.firstfloor.org> <20130501115125.GA19497@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130501115125.GA19497@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 28 * Ingo Molnar wrote: > > I don't think you want to spend that many cycles in the NMI > > handler for a dubious feature. Ok in theory you could > > add something with binary search, but that would be quite > > a bit of effort and it would be probably challenging > > to do that all NMI safe. > > If anyone using LBR sees that overhead it can be improved. You or others > who care can improve it. Also, improving the performance of is_module_text() shouldn't be too hard: an RCU rbtree should be enough. It's NMI-safe: when the rb-tree is in the middle of a rotation we'll simply not find the address and 'revert' to the worst case non-filtering your patch does all the time, but in the likely case it does find it and works as expected. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/