MIME-Version: 1.0
In-Reply-To: <20130501191342.GH17814@two.firstfloor.org>
References: <1367261108-9567-1-git-send-email-andi@firstfloor.org>
	<20130501090718.GA28253@dyad.programming.kicks-ass.net>
	<m261z3uipb.fsf@firstfloor.org>
	<20130501111219.GF28253@dyad.programming.kicks-ass.net>
	<CABPqkBT-VdWQ0c5AASDfQLssBRSfbtoH0-L1eHMXONqe5d_YRw@mail.gmail.com>
	<20130501191342.GH17814@two.firstfloor.org>
Date: Wed, 1 May 2013 21:21:55 +0200
Message-ID: <CABPqkBS7FxoT1fioe_VdBMcLAdZtfwRiMmSMocSY5TB3QAyPQQ@mail.gmail.com>
Subject: Re: [PATCH] perf, x86: Add workaround for MEM_*_RETIRED errata BV98
From: Stephane Eranian <eranian@google.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Peter Zijlstra <peterz@infradead.org>, "mingo@elte.hu" <mingo@elte.hu>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1132
Lines: 28

On Wed, May 1, 2013 at 9:13 PM, Andi Kleen <andi@firstfloor.org> wrote:
>> Unfortunately, Andi's patch fails to correct the problem though
>> it is the right approach. As he said, the problem is unfortunately
>
> perf stat -a / record -a / top will work.
>
But it does not for perf stat -a. Look at my example, run it on your machine.

> The case it doesn't fix is per thread when the other sibling
> is not running a counter.
>
> Essentially with the patch you may still get under-counting
> on these specific events if they run per thread (or are really
> unlucky in multiplexing), but never over-counting on anything.
>
> In the past Ingo's guidance was to focus on the most common
> use cases, which I think this patch does.
>
> It would be possible to fix the per thread mode too, but it would
> need quite a bit of new infrastructure and I have doubts that's
> worth it.
>
> -Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/