Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757242Ab3EAUX5 (ORCPT ); Wed, 1 May 2013 16:23:57 -0400 Received: from casper.infradead.org ([85.118.1.10]:56654 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756988Ab3EAUXz (ORCPT ); Wed, 1 May 2013 16:23:55 -0400 Message-ID: <518179BD.3010407@infradead.org> Date: Wed, 01 May 2013 13:23:25 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: David Rientjes CC: "Yann E. MORIN" , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media , linux-kbuild@vger.kernel.org Subject: Re: linux-next: Tree for May 1 (media/usb/stk1160) References: <20130501183734.7ad1efca2d06e75432edabbd@canb.auug.org.au> <518157EB.3010700@infradead.org> <20130501192845.GA18811@free.fr> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1701 Lines: 43 On 05/01/13 12:58, David Rientjes wrote: > On Wed, 1 May 2013, Yann E. MORIN wrote: > >>> When CONFIG_SND=m and CONFIG_SND_AC97_CODEC=m and >>> CONFIG_VIDEO_STK1160=y >>> CONFIG_VIDEO_STK1160_AC97=y >>> >>> drivers/built-in.o: In function `stk1160_ac97_register': >>> (.text+0x122706): undefined reference to `snd_card_create' >>> drivers/built-in.o: In function `stk1160_ac97_register': >>> (.text+0x1227b2): undefined reference to `snd_ac97_bus' >>> drivers/built-in.o: In function `stk1160_ac97_register': >>> (.text+0x1227cd): undefined reference to `snd_card_free' >>> drivers/built-in.o: In function `stk1160_ac97_register': >>> (.text+0x12281b): undefined reference to `snd_ac97_mixer' >>> drivers/built-in.o: In function `stk1160_ac97_register': >>> (.text+0x122832): undefined reference to `snd_card_register' >>> drivers/built-in.o: In function `stk1160_ac97_unregister': >>> (.text+0x12285e): undefined reference to `snd_card_free' >>> >>> >>> This kconfig fragment: >>> config VIDEO_STK1160_AC97 >>> bool "STK1160 AC97 codec support" >>> depends on VIDEO_STK1160 && SND > > This doesn't depend on SND, it depends on SND=y. > -- Maybe this option *should* depend on SND=y, but that's not what the kconfig syntax says. The kconfig language does not care if the variable is a bool or a tristate when evaluating a depends expression AFAICT (but I am only reading Documentation/kbuild/kconfig-language.txt, not the source code). -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/