Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759764Ab3EAWhb (ORCPT ); Wed, 1 May 2013 18:37:31 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:58042 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757441Ab3EAWha (ORCPT ); Wed, 1 May 2013 18:37:30 -0400 Date: Wed, 1 May 2013 15:37:28 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Borislav Petkov cc: Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Pekka Enberg , levinsasha928@gmail.com, mtosatti@redhat.com, tglx@linutronix.de, Borislav Petkov , fengguang.wu@intel.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/urgent] x86/kconfig: Add a Kconfig shortcut for building working KVM guest kernels In-Reply-To: <20130501222850.GB15623@pd.tnic> Message-ID: References: <20130426095140.GA15361@pd.tnic> <20130501203500.GC4466@pd.tnic> <20130501211011.GD4466@pd.tnic> <20130501215604.GA15623@pd.tnic> <20130501222850.GB15623@pd.tnic> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1360 Lines: 31 On Thu, 2 May 2013, Borislav Petkov wrote: > Ok, so let's step back a bit here: I've added this option with the idea > to have it as a shortcut so that you don't go search for every commodity > option when you want to boot the kernel as a kvm guest. Currently I have > it in all.config when doing randconfig builds here. While I'm doing the > randbuilds, why not boot it in kvm too while at it. > If that shortcut is enabling options that fail to build, it may not be considered so useful. > So I'm pretty sure we won't be able to plug all holes. However, let's > try to plug only those which hinder *real* usage instead of contrived > stuff. > It's contrived to not have CONFIG_NET_CORE enabled? And why are you enabling CONFIG_PCI_MSI for systems that don't have ARCH_SUPPORTS_MSI? You need CONFIG_X86_LOCAL_APIC and CONFIG_X86_IO_APIC. So let's take a step back from your step back: you want to have a shortcut to build a guest. Great, so you're enabling options that such a kernel needs. The problem is that you're neglecting options that those options need. It means your patch is incomplete. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/