Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336Ab3EBH3W (ORCPT ); Thu, 2 May 2013 03:29:22 -0400 Received: from merlin.infradead.org ([205.233.59.134]:43683 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407Ab3EBH3U (ORCPT ); Thu, 2 May 2013 03:29:20 -0400 Date: Thu, 2 May 2013 09:27:43 +0200 From: Peter Zijlstra To: "Paul E. McKenney" Cc: Julian Anastasov , Simon Horman , Eric Dumazet , Ingo Molnar , lvs-devel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Pablo Neira Ayuso , Dipankar Sarma Subject: Re: [PATCH v2 1/2] sched: Add cond_resched_rcu_lock() helper Message-ID: <20130502072742.GF7521@dyad.programming.kicks-ass.net> References: <1367290378-29224-1-git-send-email-horms@verge.net.au> <1367290378-29224-2-git-send-email-horms@verge.net.au> <20130430072944.GA13959@verge.net.au> <20130501091012.GB28253@dyad.programming.kicks-ass.net> <20130501124637.GO3780@linux.vnet.ibm.com> <20130501143258.GA31577@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130501143258.GA31577@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 20 On Wed, May 01, 2013 at 07:32:58AM -0700, Paul E. McKenney wrote: > Here is how to detect this: > > static void inline cond_resched_rcu_lock(void) > { > rcu_read_unlock(); > WARN_ON_ONCE(rcu_read_lock_held()); > #ifndef CONFIG_PREEMPT_RCU > cond_resched(); > #endif > rcu_read_lock(); > } The __might_sleep(__FILE__, __LINE__, PREEMPT_RCU_OFFSET) I posted in the other email just now should deal with this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/