Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754086Ab3EBJ4U (ORCPT ); Thu, 2 May 2013 05:56:20 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:54886 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771Ab3EBJ4T (ORCPT ); Thu, 2 May 2013 05:56:19 -0400 MIME-Version: 1.0 In-Reply-To: <87fvy53eun.fsf@devron.myhome.or.jp> References: <1367107703-2665-1-git-send-email-linkinjeon@gmail.com> <87ppxd4ddm.fsf@devron.myhome.or.jp> <87bo8v42wx.fsf@devron.myhome.or.jp> <87vc722cdu.fsf@devron.myhome.or.jp> <87r4hp3kax.fsf@devron.myhome.or.jp> <87k3nh3jzi.fsf@devron.myhome.or.jp> <87fvy53eun.fsf@devron.myhome.or.jp> Date: Thu, 2 May 2013 18:56:18 +0900 Message-ID: Subject: Re: [PATCH RESEND v5] fat: editions to support fat_fallocate From: Namjae Jeon To: OGAWA Hirofumi Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Amit Sahrawat Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1080 Lines: 28 2013/5/2, OGAWA Hirofumi : > Namjae Jeon writes: > >>>> AFAIK, preallocation != fallocate. ext*'s preallocation was there at >>>> before fallocation to optimize block allocation for user data blocks. >> yes, this is correct , preallocation!= fallocate, we just adopted only >> the "release part" from that approach >> Sorry, Would you mind to adopt this approach :) ? > > I'm ok as start if it works. > > But from this discussion, discard at last close(2) doesn't look like > working for your requirement. Since you want to discard at last close of > inode, so, rather, I guess you actually want to discard at last > dereference of inode. Okay, I see. I will check your review points again. Thanks OGAWA for review! > > Thanks. > -- > OGAWA Hirofumi > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/