Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755545Ab3EBKNA (ORCPT ); Thu, 2 May 2013 06:13:00 -0400 Received: from mail.skyhub.de ([78.46.96.112]:36969 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986Ab3EBKM6 (ORCPT ); Thu, 2 May 2013 06:12:58 -0400 Date: Thu, 2 May 2013 12:13:08 +0200 From: Borislav Petkov To: Daniel Vetter Cc: DRI Development , LKML , Dave Airlie , stable@vger.kernel.org Subject: Re: [PATCH] drm: don't check modeset locks in panic handler Message-ID: <20130502101308.GA16684@pd.tnic> References: <1367480585-22814-1-git-send-email-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1367480585-22814-1-git-send-email-daniel.vetter@ffwll.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1667 Lines: 50 On Thu, May 02, 2013 at 09:43:05AM +0200, Daniel Vetter wrote: > Since we know that locking is broken in that case and it's more > important to not flood the dmesg with random gunk. > > Cc: Dave Airlie > Cc: Borislav Petkov > References: https://groups.google.com/forum/?fromgroups=#!topic/linux.kernel/QFzFxSUeV4I Yeah, we have this nice redirector service on k.org which uses the Message-ID only and doesn't rely on some external URLs remaining stable. You could use that instead: Link: http://lkml.kernel.org/r/20130502000206.GH15623@pd.tnic > Cc: stable@vger.kernel.org > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_crtc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 792c3e3..3be0802 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -78,6 +78,10 @@ void drm_warn_on_modeset_not_all_locked(struct drm_device *dev) > { > struct drm_crtc *crtc; > > + /* Locking is currently fubar in the panic handler. */ > + if (oops_in_progress) > + return; > + > list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) > WARN_ON(!mutex_is_locked(&crtc->mutex)); Yep, thanks. Reported-and-tested-by: Borislav Petkov -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/