Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758694Ab3EBMtL (ORCPT ); Thu, 2 May 2013 08:49:11 -0400 Received: from relay3.sgi.com ([192.48.152.1]:47777 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757060Ab3EBMtK (ORCPT ); Thu, 2 May 2013 08:49:10 -0400 Date: Thu, 2 May 2013 07:49:06 -0500 From: Robin Holt To: Ingo Molnar Cc: Robin Holt , Andrew Morton , "H. Peter Anvin" , Russell King , Guan Xuetao , Miguel Boton , Russ Anderson , Linux Kernel Mailing List , the arch/x86 maintainers , Arm Mailing List Subject: Re: [PATCH -v7 10/11] arm, change reboot_mode to use enum reboot_mode Message-ID: <20130502124906.GW3658@sgi.com> References: <1367428011-17123-1-git-send-email-holt@sgi.com> <1367428011-17123-11-git-send-email-holt@sgi.com> <20130502073020.GC26361@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130502073020.GC26361@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 35 On Thu, May 02, 2013 at 09:30:20AM +0200, Ingo Molnar wrote: > > * Robin Holt wrote: > > > #ifndef __ASSEMBLY__ > > > > #include > > +#include > > > > void iop3xx_map_io(void); > > void iop_init_cp6_handler(void); > > void iop_init_time(unsigned long tickrate); > > -void iop3xx_restart(char, const char *); > > +void iop3xx_restart(enum reboot_mode, const char *); > > IMO the introduction of the enum is making things cleaner here all around. > > As long as it's an equivalent transformation for ARM with no reduction in > functionality (i.e. please fix any bugs Russell found), this all looks > like a nice series. > > Is there no parameter namespace clash between reboot modifier strings on > various architectures? I.e. 's' meaning something on x86 and meaning a > different thing on ARM or some other architecture. There is. I used an #ifdef in kernel/reboot.c. Also w[arm] | c[old] on x86 becomes s[oft] | h[ard] | g[pio] on arm/unicore32. (Well, I just added gpio that to the patch set after noticing I missed it earlier). Robin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/